From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 1/3] Use register_size () instead of MAX_REGISTER_SIZE
Date: Wed, 18 Jan 2017 08:57:00 -0000 [thread overview]
Message-ID: <20170118085634.GK28060@E107787-LIN> (raw)
In-Reply-To: <902F747B-B822-4629-8DB8-D6775357E6A5@arm.com>
On 17-01-09 10:55:18, Alan Hayward wrote:
> Aarch64 SVE requires a max register size of 256. The current max size in gdb
> is 64. This is part of a series demonstrating the replacement of
> MAX_REGISTER_SIZE.
>
> In cases where a buffer is created to hold a single register, then
> MAX_REGISTER_SIZE can be replaced with a call to register_size ().
>
> This patch is restricted to amd64-tdep.c, remote.c and regcache.c.
> Follow on patch sets will expand to other files.
>
> Tested on x86.
> Ok to commit?
>
> Thanks,
> Alan.
>
Nits on ChangeLog,
> 2017-01-09 Alan Hayward <alan.hayward@arm.com>
two spaces between date and name.
>
> * amd64-tdep.c (amd64_pseudo_register_read_value): remove
^^^^^ tab rather than spaces.
> MAX_REGISTER_SIZE.
* amd64-tdep.c (amd64_pseudo_register_read_value): Use
register_size instead of MAX_REGISTER_SIZE.
> (amd64_pseudo_register_read_value): Likewise.
> * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE.
> (store_register_using_P): Likewise.
> * regcache.c (regcache_xfer_part): Likewise.
otherwise, patch is good to me.
--
Yao (é½å°§)
prev parent reply other threads:[~2017-01-18 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 10:55 Alan Hayward
2017-01-09 20:07 ` Luis Machado
2017-01-10 11:28 ` Alan Hayward
2017-01-18 8:57 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118085634.GK28060@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox