From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57054 invoked by alias); 13 Jan 2017 12:23:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57029 invoked by uid 89); 13 Jan 2017 12:23:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jan 2017 12:23:31 +0000 Received: by mail-wm0-f68.google.com with SMTP id r144so11303348wme.0; Fri, 13 Jan 2017 04:23:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NCuQletVf5tVbDzde2aPLIhaG3n26F/kzFlLGfJDExo=; b=g2sZhc/8hCDmki85/zNIa3ocrWOe0fhfNxIM4ehW5ZDdCQ/361eXtQZdgd7p4uTs4Z ON2cPyMnabBcG4IA7VTVBBz4MeBiwiZYSFqimePQ3HUmblvb62HxQ/Ll7cljG8x1vuDU RHLfiuJNlGiO2Du7C8/Tie53m/w7JArsmWg5AA0qah7P/vCeeUaQH8cpoHVvkBCuxO5U 66nC+DprRENoVA4HlFuq+pBWoYnmC5iVPiQx563PRL6mKK+5dGUuSiaVcgJhiDuH/rH2 4YHrkRUW3nrKeqFYM2cYsKdnpP4+3hTN2Xn1arymMIRD00UC7BOf7NDv8CCzvR8igCw4 HgqA== X-Gm-Message-State: AIkVDXLMHHgum7gN9BGh5q8CdBWK9FyiigEK0u5ag/CUMy+17c2Y0jBCeCHspyiuf6GcKg== X-Received: by 10.28.35.142 with SMTP id j136mr1962987wmj.11.1484310209831; Fri, 13 Jan 2017 04:23:29 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id u78sm3946771wma.11.2017.01.13.04.23.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 13 Jan 2017 04:23:29 -0800 (PST) Date: Fri, 13 Jan 2017 12:23:00 -0000 From: Yao Qi To: Alan Modra Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg Message-ID: <20170113122316.GB28060@E107787-LIN> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-6-git-send-email-yao.qi@linaro.org> <20170111221405.GH32333@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170111221405.GH32333@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00266.txt.bz2 On 17-01-12 08:44:06, Alan Modra wrote: > On Tue, Jan 10, 2017 at 12:26:15PM +0000, Yao Qi wrote: > > * m68k-dis.c (enum print_insn_arg_error): New. > > (NEXTBYTE): Replace -3 with > > PRINT_INSN_ARG_MEMORY_ERROR. > > (NEXTULONG): Likewise. > > (NEXTSINGLE): Likewise. > > (NEXTDOUBLE): Likewise. > > (NEXTDOUBLE): Likewise. > > (NEXTPACKED): Likewise. > > (FETCH_DATA): Update comments. > > (print_insn_arg): Update comments. Replace magic numbers with > > enum. > > (match_insn_m68k): Likewise. > > OK. > Patch is pushed in. -- Yao (齐尧)