From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51395 invoked by alias); 11 Jan 2017 22:15:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51322 invoked by uid 89); 11 Jan 2017 22:15:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=print_insn_m68k, m68k_scan_mask X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 22:15:20 +0000 Received: by mail-pf0-f194.google.com with SMTP id b22so185555pfd.3; Wed, 11 Jan 2017 14:15:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M6yo55gn0zDWC+yylgIzCNTxOmksW5lI482nYcXhV6A=; b=q8+jWR/FxvdNexeLRCs2H1ouyruLNNUg+0KkDtZuycUBLv1PuxHNV1BwbsstSqb5Wr wBxkTNE7RJVbn7qQzMO7cOTAOdduzbea4Q5+5tzIJT39GTUtmtRlklmqjOjmBoM2LUDe OFlozue2JLr4wTRv0oQ01lPP6tbQU7I6X6s1RU3xLrZ+gfn6XkIPwD3oP2mc1NE6UtEO zn+nCgnNAnjRo23DZ2wmtQVN9R6iMDg9byKVm0BwJbaBDIg7wK7WZWG+L78ZudDn4xIH CzsShU20cRp70zk3EpYtPWn3ENiHaH5Q/qjtqWWyanHFBMU55KeVAT2R9G67pceWhTVZ T3Fg== X-Gm-Message-State: AIkVDXJ8ZP+DQ8I7S6qMexc5CDuDFOQ/yKIfyHrC71TjsRRIZkl8mKyqV0eDP5xS+r2TEQ== X-Received: by 10.84.216.91 with SMTP id f27mr16454832plj.92.1484172919040; Wed, 11 Jan 2017 14:15:19 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id o89sm16087044pfi.26.2017.01.11.14.15.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 14:15:18 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id BB3DBC1C43; Thu, 12 Jan 2017 08:45:14 +1030 (ACDT) Date: Wed, 11 Jan 2017 22:15:00 -0000 From: Alan Modra To: Yao Qi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 6/8] Return -1 on memory error in print_insn_m68k Message-ID: <20170111221514.GI32333@bubble.grove.modra.org> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-7-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484051178-16013-7-git-send-email-yao.qi@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2017-01/txt/msg00202.txt.bz2 On Tue, Jan 10, 2017 at 12:26:16PM +0000, Yao Qi wrote: > * m68k-dis.c (match_insn_m68k): Extend comments. Return -1 > if FETCH_DATA returns 0. > (m68k_scan_mask): Likewise. > (print_insn_m68k): Update code to handle -1 return value. This misses one FETCH_DATA call, in m68k_scan_mask. -- Alan Modra Australia Development Lab, IBM