From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32667 invoked by alias); 11 Jan 2017 22:14:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32586 invoked by uid 89); 11 Jan 2017 22:14:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=print_insn_arg, UD:m68k-dis.c, m68k-dis.c, m68kdisc X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 22:14:12 +0000 Received: by mail-pf0-f196.google.com with SMTP id y143so197718pfb.1; Wed, 11 Jan 2017 14:14:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=POiBScp49qYOJNTDFHPKHe5K8m8BtBiOcIQhQbVwekk=; b=pI/dEy3vwBbvZns9YId6Xgi+C3nkcTb/cLbTisU+pTzr0DNfUd+aIWMAcEqM38wUhK Y3cv0G/VbJj13QrTPoG8L9H6RxxRv6eb6b3d7C90KtJs7xQV5AC9zgew5ING07ai97l/ io+cb7/WyD4azXY9IFSOoJz7VFRpKQLlxblcncrkZljQoFrAhn/yg+tlzPnN7m8IoibE tewHPPE9Au3Wd9Eu6kWhtwqp/uo4vjhyWZHAIzGCyQIBOOauuwss2fkmv1BoGcMbO58V LErgBTDwQloXTvtbYUNuczsl2Fnn70TK2CikqD5/QvaOGZ3EY2lPEynm379/ZIhq35H2 BmAg== X-Gm-Message-State: AIkVDXIY9E2KFwIqK/F1gQtCKYQ/1YZsymK+FIL6CJk6nJEU7YIarc215F+Zh6mu1u0Jyw== X-Received: by 10.84.202.12 with SMTP id w12mr16757653pld.156.1484172850842; Wed, 11 Jan 2017 14:14:10 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id p2sm16179419pgd.17.2017.01.11.14.14.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 14:14:10 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 12B18C1C43; Thu, 12 Jan 2017 08:44:06 +1030 (ACDT) Date: Wed, 11 Jan 2017 22:14:00 -0000 From: Alan Modra To: Yao Qi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg Message-ID: <20170111221405.GH32333@bubble.grove.modra.org> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-6-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484051178-16013-6-git-send-email-yao.qi@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2017-01/txt/msg00201.txt.bz2 On Tue, Jan 10, 2017 at 12:26:15PM +0000, Yao Qi wrote: > * m68k-dis.c (enum print_insn_arg_error): New. > (NEXTBYTE): Replace -3 with > PRINT_INSN_ARG_MEMORY_ERROR. > (NEXTULONG): Likewise. > (NEXTSINGLE): Likewise. > (NEXTDOUBLE): Likewise. > (NEXTDOUBLE): Likewise. > (NEXTPACKED): Likewise. > (FETCH_DATA): Update comments. > (print_insn_arg): Update comments. Replace magic numbers with > enum. > (match_insn_m68k): Likewise. OK. -- Alan Modra Australia Development Lab, IBM