From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63519 invoked by alias); 11 Jan 2017 21:54:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63497 invoked by uid 89); 11 Jan 2017 21:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=msp430disc, msp430-dis.c, UD:msp430-dis.c, sk:msp430x X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 21:54:52 +0000 Received: by mail-pf0-f193.google.com with SMTP id f144so134941pfa.2; Wed, 11 Jan 2017 13:54:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bEZr/1EAE6IQE1is32TuF1xCbuKV+IIvi+uWEgHsmq0=; b=QE5FEDA/fkRGnnk/by4JGPrJE6bpsofC8VgPdnF5DIw9U4j2KXjOEWR+xXvEpbZ6rM KFTe1ql6SjDr0Z5mLdUhlh5UAr10c2IvJRMc8IRYkZ+7iSSS++KQXxnTdP2PiqXLurEg dwGznTZu2B8icMziMqcb93DjN5CeBHxdb9Tix/YPh7XW1kQOTlxsTGtvIf7+Lj/hOpj0 nUU6dmajAkb5V27KhOA1a8lc+l8TXJNYy5aQw1bW0BRPZRNbMRrJg3h6oT56yqi2bZAD R9vcVo7BxxUH6fQMbLXmiKYJ4P4cZ8XvydPJoRW1jCiAJl+YOsB4D0Ff3T2fl4jTgYy5 8TWw== X-Gm-Message-State: AIkVDXK3RtppmbsxLBnp+U7eGmPM4DCup6MlcUZk70iTBjK2Iqf5WbcYzALBEd8vi6MBug== X-Received: by 10.99.159.26 with SMTP id g26mr13456326pge.62.1484171690913; Wed, 11 Jan 2017 13:54:50 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id k76sm265626pfg.42.2017.01.11.13.54.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 13:54:50 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 5A420C1C43; Thu, 12 Jan 2017 08:24:46 +1030 (ACDT) Date: Wed, 11 Jan 2017 21:54:00 -0000 From: Alan Modra To: Yao Qi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] Return -1 on memory error in print_insn_msp430 Message-ID: <20170111215446.GG32333@bubble.grove.modra.org> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-5-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484051178-16013-5-git-send-email-yao.qi@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2017-01/txt/msg00200.txt.bz2 On Tue, Jan 10, 2017 at 12:26:14PM +0000, Yao Qi wrote: > * msp430-dis.c (msp430_singleoperand): Return -1 if > msp430dis_opcode_signed returns false. > (msp430_doubleoperand): Likewise. > (msp430_branchinstr): Return -1 if > msp430dis_opcode_unsigned returns false. > (msp430x_calla_instr): Likewise. > (print_insn_msp430): Likewise. You missed nine msp430dis_opcode_signed calls. OK with those done too. -- Alan Modra Australia Development Lab, IBM