Simon Marchi (simon.marchi@polymtl.ca): > I can comment on styling issues (some of them nits), but not so much > on the actual problem, since I'm not very familiar with it. But in > general it cleans up the code nicely I think. Thank you for your comments! All comments taken into account in the new patch in attachment. About this one: > >+ struct cmd_list_element *last_line = 0; > > This should be either "= NULL" or "= nullptr", but actually I don't > think it needs to be initialized. lookup_cmd_1 does not set this parameter when it is initialized to NULL. However, the name of the variable was a thinko. I changed it to "result_list".