From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26018 invoked by alias); 10 Jan 2017 11:00:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26005 invoked by uid 89); 10 Jan 2017 11:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=0.9 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA, 4.3, 975, =e5=b0=a7?= X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 11:00:45 +0000 Received: by mail-wm0-f67.google.com with SMTP id l2so28886385wml.2 for ; Tue, 10 Jan 2017 03:00:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GrV44K4Gz2dDyOoUnDBy20JlDuCaCMnNh/JlqR4apFM=; b=sqewbhU0rDcGjCUYYScsLz34P+AhaYGbjd1z3opT4O2vhBpNZSsG1XD7pV/UPOOXxy 1v9j/oUHTVa4iKz7xab5EZMVSq3qOB8xXx6KfKI4DIQB/96Zitbw/qWXQSJf+tAjq7bN RBVSS67FfcYjWF8V7EMnQMmEo5TXeBIh0tXpUB3+EbVxn+JW4/2fI0+xZqlM5bqVcjUL sWyDieTXJP5scuZzPiKP3j7Ut+4YbpjWfSY9oRo4RWUgpW0gPIN4orw0kWYb1FXBM4qh t8dAzZ8Sx7DJgTdhO//yCPZI0BPMt1ZH0eUDuLxsDF1EAb+9htsz6NiS+hGfq7o1oO/L 7Qow== X-Gm-Message-State: AIkVDXK5HE5UjvikmW8rqV0I0V+D0OjYX1zzDSElNHsUKzlbL7pRU5lZUbya48ch0DnD7Q== X-Received: by 10.223.152.33 with SMTP id v30mr1728397wrb.180.1484046043573; Tue, 10 Jan 2017 03:00:43 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id cs4sm2567662wjd.42.2017.01.10.03.00.41 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 10 Jan 2017 03:00:43 -0800 (PST) Date: Tue, 10 Jan 2017 11:00:00 -0000 From: Yao Qi To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Update help of the "frame" command Message-ID: <20170110110032.GE9518@E107787-LIN> References: <20170106151610.28872-1-simon.marchi@ericsson.com> <20170109172726.GA9518@E107787-LIN> <47dca06e2fcc932db67832e6c1867e92@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47dca06e2fcc932db67832e6c1867e92@polymtl.ca> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00144.txt.bz2 On 17-01-09 13:13:42, Simon Marchi wrote: > Indeed, it's the commit "Initial creation of sourceware repository". > I checked out that commit and looked at the code, but couldn't find > anything that would suggest that the output of the frame command > would not be printed when it's executing in a script or user > command. > > I went earlier using the old tarballs on the website [1], and found > that in old gdb's, there was code like this: > > 965 if (!from_tty) > 966 return; > 967 > 968 print_stack_frame (selected_frame, selected_frame_level, 1); > > The (!from_tty) check disappeared in gdb 4.3. I think it's this change: > > 873 Thu Oct 24 09:33:44 1991 John Gilmore (gnu at cygnus.com) > 874 > 875 * stack.c (frame_command): Always print. Use new > 876 frame_select_command to select a frame without printing. > > after that, the frame_command function becomes simply: > > 974 static void > 975 frame_command (level_exp, from_tty) > 976 char *level_exp; > 977 int from_tty; > 978 { > 979 select_frame_command (level_exp, from_tty); > 980 print_stack_frame (selected_frame, selected_frame_level, 1); > 981 } > > So I think it's safe. Thanks for digging it up. Patch is OK. > > Side-question, is there a git repo somewhere with all these old gdb > versions, those that predate what's in the current git tree? It > would be useful to have a repo with one commit per version. Here I > had to download many tarballs and bisect manually, but if they had > been in a repo it would have been trivial. If it doesn't exist yet, > I think I'll do it. > > [1] ftp://sourceware.org/pub/gdb/old-releases/ They were imported into the git repository. The change you found above is in b00771232fab861fb31e42dfd5f6643ba1b43cc9 -- Yao (齐尧)