From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42225 invoked by alias); 9 Jan 2017 17:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42213 invoked by uid 89); 9 Jan 2017 17:35:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA, =e5=b0=a7, 17-01-06, HTo:D*oracle.com?= X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jan 2017 17:35:26 +0000 Received: by mail-wm0-f68.google.com with SMTP id r126so3521693wmr.3 for ; Mon, 09 Jan 2017 09:35:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=E++47myRRt7SlpomQPFe4lwsDWT50SHpxv+8pUB4iYQ=; b=mS6K5dQyO94Y7Crk9IoTNgvvBKuVn2pRw2FdQSZxy+g3PxMmaKUSAxXkB18cdVl97Z 6FxQG4Is0+DhW1EquzvK1XSHb2BOMuO+9kRBh0+ZkEpA8qfggvSTY8EQ5Tn2lQvPIYx5 xR4oi3E7XiQFiaiFo+982kEjzPMGc9x4D6L4Tzr2+jMGPN28pSNkJs9Sbg4Mk5wAFdu9 Fy2aJjtTaZMgEx58uIonfCikxt+Z/OisS/u4hSLCcq3IAUfRz11QzYroJEufGnUUu5qx dDqLapbhEkMqzOoQDCE9PRre8f8+iC7ESa15WTFjLQqU8rk7KeKsOIR6n9r5gNP3eap/ AdbQ== X-Gm-Message-State: AIkVDXL+WTez2pAn8DpFTokL1904aZzuYTfIEQjgmkeRtnm7tcX5qKNdJiHMSixKDgh3Bw== X-Received: by 10.28.9.131 with SMTP id 125mr4978370wmj.22.1483983324577; Mon, 09 Jan 2017 09:35:24 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id c187sm19935368wmd.13.2017.01.09.09.35.22 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 09 Jan 2017 09:35:24 -0800 (PST) Date: Mon, 09 Jan 2017 17:35:00 -0000 From: Yao Qi To: Ivo Raisr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Bug 20936 - provide sparc and sparcv9 target description XML files Message-ID: <20170109173515.GC9518@E107787-LIN> References: <46200a1e-29f7-8e20-c0b5-3f6f25c82d45@oracle.com> <20161206152616.GC28789@E107787-LIN> <83d4c58d-0834-4fc2-6194-72408510aa8a@oracle.com> <20161212125331.GB25542@E107787-LIN> <082f9ac8-3e46-42cd-198d-91866d83ebb8@oracle.com> <20170105143109.GA21293@E107787-LIN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00128.txt.bz2 On 17-01-06 16:12:09, Ivo Raisr wrote: > > I think I see the line now as well. Please find patch #1 together > with a ChangeLog entry. > The patch was successfully built and tested on Solaris sparc. > After you find it ok, I will prepare patch #2. > I. > ChangeLog entry: > 2017-01-06 Ivo Raisr > > Split real and pseudo registers in preparation for registers provided > by a target. Registers provided by target description can have more real > registers and pseudo registers need to be positioned after them. We don't document "changes" in this way. If you think it is important to mention them, put them in the commit log. > @@ -57,6 +63,12 @@ struct gdbarch_tdep > int pc_regnum; > int npc_regnum; > > + /* Register names specific for architecture (sparc32 vs. sparc64) */ > + const char **fpu_register_names; > + size_t fpu_registers_num; > + const char **cp0_register_names; > + size_t cp0_registers_num; > + These four fields are added, but not used at all, so could you move them to patch #2? -- Yao (齐尧)