From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117377 invoked by alias); 9 Jan 2017 17:31:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115954 invoked by uid 89); 9 Jan 2017 17:31:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA, H*MI:sk:2016120, Antoine, =e5=b0=a7?= X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jan 2017 17:31:08 +0000 Received: by mail-wm0-f68.google.com with SMTP id c85so23620339wmi.1 for ; Mon, 09 Jan 2017 09:31:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lk0S/MSVUyLjErFevQ1V98fPNc843QyW2KvihctzG8o=; b=rc+Q9FeKifxudcCaD+JE1YJXox1pSJD3K91bZLqbXe6UJwU1+D6LS54SjW9EqPWiog k2LIfohPetRle/5EsNmv5no7igajLZyWy11TuPTJJfgx4vIjPvUZgGPL/PHKEq9PDl13 4ClMrvEUpPTBlPU3BnFcEshl3EakA5d+w1IYmFp9jpHt+p7nT5ZMSrU6lu22rXEaZcUZ 3XnxFTXJ8eZwsmaf7gkNu5/5RDHq4pSSAXyXnXqVPtQXUG352yrcfK1pmjd/QvaGxRpA xq9tXdneh//1Bnxkz6vmWA50qIYoSVBjw1bYoZKEqNep/IXB1B9ON7+5yufKXPry6lYy qQHw== X-Gm-Message-State: AIkVDXI57bdG/Cr6lmyrQaxMrnXF54oNTcg8n3MY37oJ3qhobcY1Kse3qG0mo9XFxVJsOQ== X-Received: by 10.223.139.93 with SMTP id v29mr545634wra.142.1483983066132; Mon, 09 Jan 2017 09:31:06 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id x5sm124887123wje.36.2017.01.09.09.31.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 09 Jan 2017 09:31:05 -0800 (PST) Date: Mon, 09 Jan 2017 17:31:00 -0000 From: Yao Qi To: Antoine Tremblay Cc: qiyaoltc@gmail.co, gdb-patches@sourceware.org Subject: Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32 Message-ID: <20170109173056.GB9518@E107787-LIN> References: <20161209122339.GG13661@E107787-LIN> <20161209124625.31861-1-antoine.tremblay@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161209124625.31861-1-antoine.tremblay@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00127.txt.bz2 On 16-12-09 07:46:25, Antoine Tremblay wrote: > > This situation is tested with non-stop-fair-events.exp. > > In other words, single-step breakpoints are installed in proceed_one_lwp > for each thread. GDBserver proceeds two threads for resume_step, as > requested by GDB, and the thread proceeded later may see the single-step > breakpoints installed for the thread proceeded just now. > > Tested on gdbserver-native/-m{thumb,arm} no regressions. I assume this patch fixes fails in non-stop-fair-events.exp. > > gdb/gdbserver/ChangeLog: > > * linux-aarch32-low.c (arm_breakpoint_kind_from_pc): Use > target_read_memory. > * linux-arm-low.c (get_next_pcs_read_memory_unsigned_integer): Likewise. > (get_next_pcs_syscall_next_pc): Likewise. Patch is good to me. -- Yao (齐尧)