From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48641 invoked by alias); 5 Jan 2017 17:31:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48626 invoked by uid 89); 5 Jan 2017 17:31:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA, =e5=b0=a7?= X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jan 2017 17:31:06 +0000 Received: by mail-wm0-f50.google.com with SMTP id k184so297564201wme.1 for ; Thu, 05 Jan 2017 09:31:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xCTKJnAXAyxMKz1mB7Oq0i7j/nggcMzSeOKjkMIPco8=; b=fnToB3NvSFviboQWhU0H6uylqggveJFk3T5rC9gQTemkUT0fRwXzKwosaaT4LQVEgf T27aq0KNh/Anp0AW4NnaWvRDQkirh80liibj29KJHi7MsCwV9B0khc+708F/1/AUTHEL Mwt8IKLLsJFvFKs2gQpPNvL9ZxGomPMCwcTu2UZdmjaGeQ9Ra1msUGM8cMvGUpQzmcbn u9Tvbv/PMvL3qjlMocNH9VLO4DXXyzwqP6XFUX8DQXXlnEmuT3gyBvZk3vSuv7zv/WiH PflIZ9Lka+hyaV5org8RroWOPN7KbhLOjtkrQKBXSZc0o8ZKnMoey1tSb+YsmWxBj3G0 QIhA== X-Gm-Message-State: AIkVDXL5hJgA8Aq9kcuVpXq8uXQlAUi6s0lhJYCh28QkAD0I0NAXDNSHw87HJCIkKQLbhw== X-Received: by 10.28.164.196 with SMTP id n187mr61383839wme.44.1483637464586; Thu, 05 Jan 2017 09:31:04 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id d9sm75715192wje.14.2017.01.05.09.31.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 05 Jan 2017 09:31:03 -0800 (PST) Date: Thu, 05 Jan 2017 17:31:00 -0000 From: Yao Qi To: Iain Buclaw Cc: Luis Machado , GDB Patches Subject: Re: [PATCH] D: Fix crash when expression debugging Message-ID: <20170105173057.GB21293@E107787-LIN> References: <5806a075-dc30-b664-a834-a633b3b27256@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00079.txt.bz2 On 17-01-04 21:38:07, Iain Buclaw wrote: > >>>> +if { [skip_d_tests] } { continue } > >>> > >>> We should output a message: > >>> > >>> untested "skipping d language tests" > >>> > >>> It may be more reasonable to just return instead of continuing? The > >>> effect > >>> will probably be the same, but it is a bit confusing to read "continue" > >>> without a visible loop. > >>> > >> > >> I did a quick grep, and it seems like everyone is skippingtests in > >> this way except for gdb.ada and gdb.btrace which are doing { return -1 > >> } > >> > >> > > > > That's a bit of a stretch. Take, for example, a few of the examples in > > gdb.base. You will see a number of them returning. > > > > The problem here is inheriting past confusing practices when we use some > > existing files to create new ones, which is not your fault really. I'm > > guilty myself. :-) > > > > Yes indeed. I wasn't disagreeing, just questioning the two competing > ways of returning. > > I will update to use return and push this in then if there's no > disagreement. :-) > "return" is clearer than "continue", and "return" is preferred in https://www.sourceware.org/gdb/wiki/GDBTestcaseCookbook -- Yao (齐尧)