From: Mike Frysinger <vapier@gentoo.org>
To: Jim Wilson <jim.wilson@linaro.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH] fix for aarch64 sim tbnz bug
Date: Mon, 12 Dec 2016 18:42:00 -0000 [thread overview]
Message-ID: <20161212184245.GU10558@vapier.lan> (raw)
In-Reply-To: <CABXYE2WEVB=Bt=+uX7Sx6a9ZE4etGwFODLKnyeOzW52P+Rhe3w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 04 Dec 2016 19:43, Jim Wilson wrote:
> --- a/sim/testsuite/sim/aarch64/testutils.inc
> +++ b/sim/testsuite/sim/aarch64/testutils.inc
> @@ -43,11 +43,11 @@
>
> swiwrite 5
> exit 0
> + .endm
>
> .data
> .Lpass:
> .asciz "pass\n"
> - .endm
>
> # MACRO: fail
> # Write 'fail' to stdout and quit
> @@ -56,12 +56,12 @@
> adrp x1, .Lfail
> add x1, x1, :lo12:.Lfail
> swiwrite 5
> - exit 0
> + exit 1
> + .endm
>
> .data
> .Lfail:
> .asciz "fail\n"
> - .endm
>
> # MACRO: start
> # All assembler tests should start with a call to "start"
i think you want to stuff those pass/fail strings into the
start macro instead of just having it get inserted where the
include happened to show up.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-12 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 4:49 Jim Wilson
2016-12-02 9:32 ` Mike Frysinger
2016-12-05 3:45 ` Jim Wilson
2016-12-12 18:38 ` Jim Wilson
2016-12-12 18:42 ` Mike Frysinger [this message]
2016-12-13 0:33 ` Jim Wilson
2016-12-13 6:38 ` Mike Frysinger
2016-12-13 10:45 ` Nick Clifton
2016-12-02 12:03 ` Nick Clifton
2016-12-02 15:59 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212184245.GU10558@vapier.lan \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=jim.wilson@linaro.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox