From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: extern modifier on function declarations
Date: Fri, 09 Dec 2016 09:23:00 -0000 [thread overview]
Message-ID: <20161209092244.GA13661@E107787-LIN> (raw)
In-Reply-To: <9c9c81880b49120bf90766fce93503ac@simark.ca>
On 16-12-08 10:45:10, Simon Marchi wrote:
> Hi gdb-patches,
>
> Our coding style currently requires using the "extern" keyword on
> function declarations. How relevant is this today?
>
> I am not good at reading standards, but it is my impression that in
> C++, functions are always extern unless they are declared static. I
> am sure some people here know that answer already.
>
> If it's not useful anymore, I would suggest dropping it for future
> patches. It doesn't change much, just a bit less verbosity and line
> wrapping.
I'd like to keep "extern", with respect to consistency. As we move to
C++, I don't expect many new function declarations, instead, I expect
more classes are added and used. Even some existing code can be
converted to classes. In the long term, there should be less and less
function declarations.
--
Yao (é½å°§)
prev parent reply other threads:[~2016-12-09 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 15:45 Simon Marchi
2016-12-09 9:23 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209092244.GA13661@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox