From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87080 invoked by alias); 6 Dec 2016 15:26:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86982 invoked by uid 89); 6 Dec 2016 15:26:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2824, H*f:sk:46200a1, H*i:sk:46200a1, Hx-spam-relays-external:74.125.82.66 X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Dec 2016 15:26:32 +0000 Received: by mail-wm0-f66.google.com with SMTP id u144so22094764wmu.0 for ; Tue, 06 Dec 2016 07:26:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=vn61dId7P/WLrQw5DDRoiGiwPAOxH6w9/WjEKW9/9BI=; b=jHjZDuigApJAxtR0A2m6+IFicTslUArjvXMJHZjOsO2/AVljqL/PINcI9bRDWHhPP5 EoWIJ5JT9XoOBIfZ4nJCwvVuF2e4s4Ilgc4hRkIKRto/zq6L6I5UsRkMimHWY0HsurZ8 jEQaPBwywpT2NQOjDiLX7MQKQ74i0DpgGFyaxokuX1sttxfYep16M4S9kqxXBZ2fxCh8 X3bnDofXeRqqHC5QJsLU3owVsAzwR/YR1N3xCL1JSu6s+87ciVxLlcXmnaQLKC4jBpvF txokGkCXuWmZyp6BMcp9xvt1Ojdn4PsKCQvuP/04gHEzRpYgfFmUzSuXY/xsxqIcxRE1 s5bA== X-Gm-Message-State: AKaTC02xuXUgQgI4Gxi6COh0CoEhyjU42vnOLPOFidICBEN94Xd+gRt21QKjONQ6MueBKA== X-Received: by 10.28.10.147 with SMTP id 141mr3106684wmk.65.1481037990799; Tue, 06 Dec 2016 07:26:30 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id w8sm4552613wmw.4.2016.12.06.07.26.28 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 06 Dec 2016 07:26:30 -0800 (PST) Date: Tue, 06 Dec 2016 15:26:00 -0000 From: Yao Qi To: Ivo Raisr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Bug 20936 - provide sparc and sparcv9 target description XML files Message-ID: <20161206152616.GC28789@E107787-LIN> References: <46200a1e-29f7-8e20-c0b5-3f6f25c82d45@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46200a1e-29f7-8e20-c0b5-3f6f25c82d45@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00167.txt.bz2 On 16-12-06 11:40:42, Ivo Raisr wrote: > Please find attached a patch which fixes PR tdep/20936. > > This patch provides sparc (32-bit) and sparcv9 (64-bit) target > description XML files. > Files sparc{64}-cp0.xml, sparc{64}-cpu.xml and sparc{64}-fpu.xml are > OS independent. > Files sparc-solaris.xml and sparc64-solaris.xml are specific to Solaris. Hi Ivo, Could you add a new directory "sparc" in gdb/features/ and put all .xml files there? > > gdb regression test suite was run successfully on Solaris/sparc. > > This PR with a patch is used as a foundation for another patch which > will enhance sparc{64}-tdep > with the ability to work the Valgrind shadow registers. Stay tuned. > I suppose your next patch is to change sparc{64}-tdep.c to use these target descriptions. I'd like to get target description definition and use in a single patch. You add some thing new in this patch, but it is not used at all. All these new added features should be documented https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html > > ChangeLog entry: > 2016-12-06 Ivo Raisr > > PR tdep/20936 > Provide sparc and sparcv9 target description XML files. Indented by tab rather than spaces. > * sparc-cp0.xml, sparc-cpu.xml, sparc-fpu.xml: New files for > sparc 32-bit. > * sparc64-cp0.xml, sparc64-cpu.xml, sparc64-fpu.xml: New files > for sparc 64-bit. > * sparc-solaris.xml, sparc64-solaris.xml, sparc-solaris.c, > sparc64-solaris.c: New files for sparc and sparc64 on Solaris. * sparc-solaris.c, sparc64-solaris.c: Generated. > diff -Npur a/gdb/features/sparc-cp0.xml b/gdb/features/sparc-cp0.xml > --- a/gdb/features/sparc-cp0.xml 1969-12-31 16:00:00.000000000 +0000 > +++ b/gdb/features/sparc-cp0.xml 2016-12-06 03:07:35.249368327 +0000 > @@ -0,0 +1,19 @@ > + > + > + > + > + > + > + > + > + > + > + I suspect the type should be code_ptr. > + > + > + > + -- Yao (齐尧)