From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: qiyaoltc@gmail.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Assert on lval_register
Date: Tue, 06 Dec 2016 13:13:00 -0000 [thread overview]
Message-ID: <20161206131328.D7D4810FC4B@oc8523832656.ibm.com> (raw)
In-Reply-To: <20161206101513.GA28789@E107787-LIN> from "Yao Qi" at Dec 06, 2016 10:15:13 AM
Yao Qi wrote:
> On 16-11-30 22:16:37, Ulrich Weigand wrote:
> > I think we should simply get rid of frame_register_unwind. Callers
> > should be changed to use frame_unwind_register_value directly, and
> > just operate on the value.
>
> Yeah, that is what I was trying to do, but we should be careful on
> the value management in the end of frame_register_unwind,
>
> /* Dispose of the new value. This prevents watchpoints from
> trying to watch the saved frame pointer. */
> release_value (value);
> value_free (value);
Right. Those callers that care will need to handle this themselves.
> OK, how about the patch below?
Looks good to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-12-06 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 14:56 Yao Qi
2016-11-30 21:16 ` Ulrich Weigand
2016-12-06 10:15 ` Yao Qi
2016-12-06 13:13 ` Ulrich Weigand [this message]
2016-12-06 14:26 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206131328.D7D4810FC4B@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox