From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95841 invoked by alias); 29 Nov 2016 20:55:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95826 invoked by uid 89); 29 Nov 2016 20:55:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=spent, our, white, wish X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 20:55:31 +0000 Received: by mail-wm0-f68.google.com with SMTP id g23so26415708wme.1 for ; Tue, 29 Nov 2016 12:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kVPwMvgUpYsSrsubRlf6ql+BBTIY9D7NmddD40d2klQ=; b=TZnyIoalWxhzerJY2NgysYRSR3hx7Uc+qcgPHrPOAypOonBrO8yl3rfXxJcHJn7Vmp BC+FWce+oEUiFp6jbl+uvJF0ZGF4eTM9+MVb9f4st/DfsBe+LfWJ1YJXFsRGF3okTg5z /F0eidTLtVJF82sHrD+W1SxLF1x/pF4TYKbVAY8CvtEGRfmtHtVj9Wa1S4guIo2eDq1O WDeyBU4OeTNDiLpqbpDJmpmonQyB67N1+xOotp9EDeDzLhPrUkiRzKOXWFFsr9dKvAMM /B5NmKwEfmqxbEAqSW6a3Ym9BMKgUQQpAqTIy9rLqDaySk67LQ43tveYtbnGeBiXF7dd TCqw== X-Gm-Message-State: AKaTC00zP8bml0IxHsj+m8gvoTbAn66gpaSxYzE3NneefuVm+FNDyYJJ5xooNVfaDLWmug== X-Received: by 10.28.197.6 with SMTP id v6mr24072693wmf.130.1480452929836; Tue, 29 Nov 2016 12:55:29 -0800 (PST) Received: from localhost ([2a02:c7d:8e80:c00:5163:1af1:2b94:f922]) by smtp.gmail.com with ESMTPSA id w7sm4583695wmd.24.2016.11.29.12.55.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2016 12:55:29 -0800 (PST) Date: Tue, 29 Nov 2016 20:55:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Message-ID: <20161129205524.xi3png66sw5quz5p@localhost> References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> <20161129144851.GF22209@E107787-LIN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00964.txt.bz2 On Tue, Nov 29, 2016 at 09:06:54AM -0600, Luis Machado wrote: > > Why just that one? Shouldn't we attempt to enforce this for all the other > proc's, so gdb_test, gdb_test_multiple, gdb_test_no_output and mi_gdb_test? > because all of them except mi_gdb_test call gdb_test_multiple. > > > > > > It can be tricky, since one is still free to start the sentences > > > with something like "ARM ..." or some other technology name. So > > > unfortunately we can't be too strict. I wish we could. > > > > Do we have some many technology names? We have a white list of these > > technology names which can be capitalized in test message. > > > > It is certainly possible, but do we want to add one more layer of > maintenance? We could enforce a rule from now on to require test names to > always start with lowercase or to even be all lowercase. > This is done by manual inspection in the patch review each time. The automatic checking is much better than manual inspection. > I don't think we're coherent with our use of lower/uppercase anyway. For > example, GDBserver gets called gdbserver in gdbserver's own help text and > the testsuite is (less so now with this series) a mixed bag. > > I'm open to ideas. We've spent some effort to convert GDB tests to comply to this rule, so I am wondering if we can find some efficient way to enforce this rule, otherwise, the violation to this rules may show up in the code some time later. -- Yao