From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55847 invoked by alias); 29 Nov 2016 14:49:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55830 invoked by uid 89); 29 Nov 2016 14:49:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=letter X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 14:49:02 +0000 Received: by mail-wm0-f67.google.com with SMTP id m203so24696580wma.3 for ; Tue, 29 Nov 2016 06:49:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZZgHbQtFW9avcsy2K8d9Pf8oNdbO1qcGFqQ8VQe6bvQ=; b=mUaHX0zbGtIFL/pUNXKKeRXIl7YC1oNVUZF1xHxEvyrY/ULPrLat+SobYNphmwpSnU w59hCrlwDAiAuURYsxFkBZrmYKTiSUS/UNI8VWKOCkKRQaCJbqkrTNzz/OlUbSlk/cYl y8NdWpMJLIUzaIF/yFFneiTiKe/fYV+n6DgLEdVb2RRyprACy+g3+7MUAdMjY5ul3206 SYbHx8nkcpG7dEJp8WODXinh2tywOSZ9+hApwohYo+3baT0C+SKKRYF22DA3bhFd1iNI n6NG8bjj49nXkEXQe0gRzW1XVLBsrSYytxIxbQyCEgZ6iVoTKnLk7R9q7WgPBNyxgAtH T4zg== X-Gm-Message-State: AKaTC03m9HReeusgwhHg4MTjWTFUP0O6UyPCOlESQDxTkcRlU3EwlpajoW3UreVHw7lGEQ== X-Received: by 10.28.51.211 with SMTP id z202mr26305184wmz.125.1480430940857; Tue, 29 Nov 2016 06:49:00 -0800 (PST) Received: from E107787-LIN (power8-aix.osuosl.org. [140.211.9.96]) by smtp.gmail.com with ESMTPSA id xu5sm68034161wjc.49.2016.11.29.06.48.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 29 Nov 2016 06:49:00 -0800 (PST) Date: Tue, 29 Nov 2016 14:49:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Message-ID: <20161129144851.GF22209@E107787-LIN> References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> <20161127170947.32vzeqciax5v275h@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00944.txt.bz2 On Mon, Nov 28, 2016 at 10:06:28AM -0600, Luis Machado wrote: > On 11/27/2016 11:09 AM, Yao Qi wrote: > >On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote: > >>This fixes offender testcases that have test names starting with uppercase > >>when using gdb_test_multiple in a single-line construct. > >> > >>gdb/testsuite/ChangeLog > >>2016-11-25 Luis Machado > >> > >> Fix test names starting with uppercase throughout the files. > >> > >> * gdb/testsuite/gdb.arch/i386-bp_permanent.exp > >> * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp > >> * gdb/testsuite/gdb.base/disasm-end-cu.exp > >> * gdb/testsuite/gdb.base/macscp.exp > >> * gdb/testsuite/gdb.base/pending.exp > >> * gdb/testsuite/gdb.base/watch_thread_num.exp > >> * gdb/testsuite/gdb.cp/exception.exp > >> * gdb/testsuite/gdb.cp/gdb2495.exp > >> * gdb/testsuite/gdb.cp/local.exp > >> * gdb/testsuite/gdb.python/py-evsignal.exp > >> * gdb/testsuite/gdb.python/python.exp > >> * gdb/testsuite/gdb.trace/tracecmd.exp > > > >Drop "gdb/testsuite/". Patch is good to me, but I think we need to > >enforce a rule in "proc gdb_test_multiple" that test message should > >start with a lower case letter, emit an ERROR if it starts with > >uppercase. > > > > Do you mean just for gdb_test_multiple? Yes, > > It can be tricky, since one is still free to start the sentences > with something like "ARM ..." or some other technology name. So > unfortunately we can't be too strict. I wish we could. Do we have some many technology names? We have a white list of these technology names which can be capitalized in test message. -- Yao (齐尧)