From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92137 invoked by alias); 28 Nov 2016 17:22:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92120 invoked by uid 89); 28 Nov 2016 17:22:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:AES128-SHA X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Nov 2016 17:22:32 +0000 Received: by mail-wm0-f67.google.com with SMTP id m203so20129187wma.3 for ; Mon, 28 Nov 2016 09:22:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ih3cuNbks4a+ShN4+XgTK1/7D1lxpcxvrBc4Q6IiSDk=; b=RuFv5b2N4dSh4yewDw8NIyNjLBvhK5vHrjrClvtqUR6TCb7dIG/JQ1lZZ/SbXtMZQD J0b03AwtZQXf8FSfvvgyI9XjfScocmtdl1bdkg1Xso50s7yG38vsJ+PWxLt/nOfStHUC 1z1U0zJlfzv7DxTGZSCpSNGHTtSYNfl87zAZSBNFpy3zHZA432wfh0W/YEVT4vLBxlXV l6tKxQbVUeXASBEU8zl6eSsspIuo35GlnrMXJiDhyp2isNI3ZQzVExN5xCp0tUyqVl4y nGOsFAxe61be5D51GJeC0Td/Ap0PEpr75N9/yC4Om4zO81fCJsVLZIf4aaHynUMU+u1u YuDA== X-Gm-Message-State: AKaTC023hMUD8YrWFgDUvWtB1nhJaHdv8ayGgjpHl/aC+Yszt9cIntPy/o7een5NjkT7zg== X-Received: by 10.28.130.137 with SMTP id e131mr19846719wmd.21.1480353748134; Mon, 28 Nov 2016 09:22:28 -0800 (PST) Received: from E107787-LIN (power8-aix.osuosl.org. [140.211.9.96]) by smtp.gmail.com with ESMTPSA id g17sm63581717wjs.38.2016.11.28.09.22.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 28 Nov 2016 09:22:27 -0800 (PST) Date: Mon, 28 Nov 2016 17:22:00 -0000 From: Yao Qi To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Restrict checking value.lval on using address Message-ID: <20161128172219.GD22209@E107787-LIN> References: <1480068407-22616-4-git-send-email-yao.qi@linaro.org> <20161125115210.2CCF310BCB8@oc8523832656.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161125115210.2CCF310BCB8@oc8523832656.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00920.txt.bz2 On Fri, Nov 25, 2016 at 12:52:10PM +0100, Ulrich Weigand wrote: > Yao Qi wrote: > > > * ada-lang.c (ensure_lval): Call set_value_address after setting > > VALUE_LVAL. > > * elfread.c (elf_gnu_ifunc_resolve_addr): Set VALUE_LVAL to > > lval_memory. > > (elf_gnu_ifunc_resolver_return_stop): Likewise. > > * value.c (value_fn_field): Likewise. > > (value_from_contents_and_address_unresolved): Likewise. > > (value_from_contents_and_address): Likewise. > > (value_address): Check value->lval isn't > > lval_memory. > > (value_raw_address): Likewise. > > (set_value_address): Assert value->lval is lval_memory. > > Looks good to me. > Patch is pushed in. -- Yao (齐尧)