From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71489 invoked by alias); 27 Nov 2016 17:10:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71460 invoked by uid 89); 27 Nov 2016 17:10:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=00pm, Hx-languages-length:1149 X-HELO: mail-wj0-f194.google.com Received: from mail-wj0-f194.google.com (HELO mail-wj0-f194.google.com) (209.85.210.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Nov 2016 17:09:52 +0000 Received: by mail-wj0-f194.google.com with SMTP id kp2so11254411wjc.0 for ; Sun, 27 Nov 2016 09:09:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sH3duSCM8f06fQ68MxGBNUyNtvVeRwnJmJYAxufREIQ=; b=Sc3pnydojTw1MQ+LofnYtZXVNXAdFFC+n7X8HQKW1UhMqY3nN3J+2CD7SRlwYrfoot YFPqNHnG61tWft6LmIA4J8G4YRN9V1zb0cZ+RSMdoU3fThhfiXjo8BM2OPTdwE4cY3n0 ZJ2Jo0WQSup37JjtNhZ3KRz3HNt1Bjfss8ELrKEl10zIOFmG9t+EbWVupV55dI4d822N PaW9L0HrpgtRV/LAwIejafHAjMIhcMUoGKwmzbZu/1xZwXIi7AUnK/a6XTun+InFfp09 MbIjWFIgwYIfz3u4cjTRu/4ttxA18RvzTs3lmyHpSv8S8jyCYGarkZ68Fhcy+lQpAFk+ VfKg== X-Gm-Message-State: AKaTC00P66AhW0DHOQfSRrCK6deeJtB10VgQvtlBa8HrHn/6oNs8hO2Z0u17AKwSNlxMFw== X-Received: by 10.194.165.136 with SMTP id yy8mr17817376wjb.14.1480266589974; Sun, 27 Nov 2016 09:09:49 -0800 (PST) Received: from localhost ([2a02:c7d:8e80:c00:4545:3b87:fec5:8e81]) by smtp.gmail.com with ESMTPSA id gk6sm40237243wjc.46.2016.11.27.09.09.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 09:09:49 -0800 (PST) Date: Sun, 27 Nov 2016 17:10:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Message-ID: <20161127170947.32vzeqciax5v275h@localhost> References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480107244-1484-5-git-send-email-lgustavo@codesourcery.com> User-Agent: NeoMutt/20161014 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00913.txt.bz2 On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote: > This fixes offender testcases that have test names starting with uppercase > when using gdb_test_multiple in a single-line construct. > > gdb/testsuite/ChangeLog > 2016-11-25 Luis Machado > > Fix test names starting with uppercase throughout the files. > > * gdb/testsuite/gdb.arch/i386-bp_permanent.exp > * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp > * gdb/testsuite/gdb.base/disasm-end-cu.exp > * gdb/testsuite/gdb.base/macscp.exp > * gdb/testsuite/gdb.base/pending.exp > * gdb/testsuite/gdb.base/watch_thread_num.exp > * gdb/testsuite/gdb.cp/exception.exp > * gdb/testsuite/gdb.cp/gdb2495.exp > * gdb/testsuite/gdb.cp/local.exp > * gdb/testsuite/gdb.python/py-evsignal.exp > * gdb/testsuite/gdb.python/python.exp > * gdb/testsuite/gdb.trace/tracecmd.exp Drop "gdb/testsuite/". Patch is good to me, but I think we need to enforce a rule in "proc gdb_test_multiple" that test message should start with a lower case letter, emit an ERROR if it starts with uppercase. -- Yao