Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple

Yao Qi
2016-11-27T17:10:03Z

On Fri, Nov 25, 2016 at 02:54:00PM -0600, Luis Machado wrote:
> This fixes offender testcases that have test names starting with uppercase
> when using gdb_test_multiple in a single-line construct.
>
> gdb/testsuite/ChangeLog
> 2016-11-25 Luis Machado <lgustavo@codesourcery.com>
>
> Fix test names starting with uppercase throughout the files.
>
> * gdb/testsuite/gdb.arch/i386-bp_permanent.exp
> * gdb/testsuite/gdb.arch/i386-gnu-cfi.exp
> * gdb/testsuite/gdb.base/disasm-end-cu.exp
> * gdb/testsuite/gdb.base/macscp.exp
> * gdb/testsuite/gdb.base/pending.exp
> * gdb/testsuite/gdb.base/watch_thread_num.exp
> * gdb/testsuite/gdb.cp/exception.exp
> * gdb/testsuite/gdb.cp/gdb2495.exp
> * gdb/testsuite/gdb.cp/local.exp
> * gdb/testsuite/gdb.python/py-evsignal.exp
> * gdb/testsuite/gdb.python/python.exp
> * gdb/testsuite/gdb.trace/tracecmd.exp

Drop "gdb/testsuite/". Patch is good to me, but I think we need to
enforce a rule in "proc gdb_test_multiple" that test message should
start with a lower case letter, emit an ERROR if it starts with
uppercase.

--
Yao