Re: [PATCH v2 5/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test

Pedro Alves
2016-11-30T20:11:25Z

On 11/25/2016 08:54 PM, Luis Machado wrote:
> This fixes offender testcases that have test names starting with uppercase
> when using gdb_test/mi_gdb_test in a multi-line construct.
>
> gdb/testsuite/ChangeLog
> 2016-11-25 Luis Machado <lgustavo@codesourcery.com>
>
> Fix test names starting with uppercase throughout the files.
>
> * gdb/testsuite/gdb.ada/array_return.exp

Drop gdb/testsuite/. Otherwise LGTM.

> diff --git a/gdb/testsuite/gdb.ada/array_return.exp b/gdb/testsuite/gdb.ada/array_return.exp
> index f4dae48..37f2845 100644
> --- a/gdb/testsuite/gdb.ada/array_return.exp
> +++ b/gdb/testsuite/gdb.ada/array_return.exp
> @@ -52,7 +52,7 @@ gdb_test "break create_small_float_vector" \
>
> gdb_test "cont" \
> "Breakpoint \[0-9\]+, pck.create_small \\(\\).*" \
> - "Continuing to Create_Small"
> + "continuing to Create_Small"

This looks like a good example showing why enforcing uppercase
in the testsuite's internal routines would be going too far.
I.e., it's quite reasonable to want to print the name of some random
symbol from the test's source code which might want to be uppercase.

> --- a/gdb/testsuite/gdb.base/testenv.exp
> +++ b/gdb/testsuite/gdb.base/testenv.exp
> @@ -49,7 +49,7 @@ gdb_breakpoint $bp_line
> # First test with no TEST_GDB_VAR
> gdb_test "continue" \
> ".*Program found 0 variables starting with TEST_GDB.*" \
> - "Test no TEST_GDB var"
> + "test no TEST_GDB var"

Another example. This time the name of an environment variable.

Thanks,
Pedro Alves