Re: [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple

Pedro Alves
2016-11-30T20:47:33Z

On 11/25/2016 08:54 PM, Luis Machado wrote:
> This fixes offender testcases that have test names starting with uppercase
> when using gdb_test_multiple in a multi-line construct.
>
> gdb/testsuite/ChangeLog
> 2016-11-25 Luis Machado <lgustavo@codesourcery.com>
>
> Fix test names starting with uppercase throughout the files.
>
> * gdb/testsuite/gdb.cp/gdb2495.exp

Drop "gdb/testsuite/", and LGTM, but ...

> ---
> gdb/testsuite/gdb.cp/gdb2495.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp
> index dff5977..7e4dfa8 100644
> --- a/gdb/testsuite/gdb.cp/gdb2495.exp
> +++ b/gdb/testsuite/gdb.cp/gdb2495.exp
> @@ -95,7 +95,7 @@ gdb_test "info breakpoints" \
>
> # Turn off this new behaviour.
> gdb_test_multiple "set unwind-on-terminating-exception off" \
> - "Turn unwind-on-terminating-exception off" {
> + "turn unwind-on-terminating-exception off" {
> -re "$gdb_prompt $" {pass "set unwinn-on-terminating-exception off"}
> timeout {fail "(timeout) set unwind-on-terminating-exception off"}
> }

... I think this could just be:

gdb_test "set unwind-on-terminating-exception off" ""

?

I'd end up fixing two extra things:

- note the typo in the pass case: "unwiNN"
- odd "(timeout)" print position. timeout handling it not necessary
at all with gdb_test_multiple, even.

Thanks,
Pedro Alves