Re: [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple

Pedro Alves
2016-11-30T19:56:00Z

On 11/29/2016 09:14 PM, Luis Machado wrote:

> Right. I agree that we don't want to have to keep inspecting things
> manually. So if we decide to go all lowercase even for technology, ISA
> or arch names, then i think we can enforce this better via the change to
> gdb_test_multiple (and mi_gdb_test). Then we don't have to maintain a
> whitelist at all.
>
> Does that sound reasonable?

Is that going a bit too far? There's no real harm in
uppercase test messages, other than inconsistency. I suspect that the
main reason we see patches with uppercase test names is people
starting from an existing test and applying the old time-proven
copy/paste test-writing methodology. So if we fix most violations, then
we should see much fewer attempts to reintroduce more. And we can't add
such enforcement until we've fixed all existing ones.

Thanks,
Pedro Alves