From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48592 invoked by alias); 27 Nov 2016 16:48:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48307 invoked by uid 89); 27 Nov 2016 16:48:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=showing, always-inserted, alwaysinserted, sk:skip_py X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Nov 2016 16:47:57 +0000 Received: by mail-wm0-f67.google.com with SMTP id u144so15209745wmu.0 for ; Sun, 27 Nov 2016 08:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BebidN7AOg7VG7kDP728RM5fgiCwe3JXMQZIRzJwSjM=; b=cHCniCEIee7yhzCa/17x3fD4dpnzFNHyOSZ6XPGFr6WLCmgAvJLaysemqTRERbk3Kx dBn6fTEJRfRkYuJjDLXphvdBVWQVW/up3TzE3w+RGyAdNDHzwotL8HeVHpbg0EWCR1T3 CLLfMUtevjUjINguBNdFX0WPDDiYppq3yrMDh/XJJm5svwSQ8pVt8REEzdFExCdEUAnZ gpIFlOKqbD0U8m0nhKnklY1+b9fHzrZdS9vMGEaoWvC1g+nouruttXw5tSM8PxB9QEzE 2/loWZPs0j1WAQgW47FvxndJ2XQMyAbmK4puy6sg73HQ5BmWwPQ/Ju8O6gxW2jEGzfct 4a1Q== X-Gm-Message-State: AKaTC01F16QKyd3BjKbQLNKFmgmqMWPadq3SrXlkfXe84ouJrBPybs9XiHR5KUp6tG0spw== X-Received: by 10.28.178.10 with SMTP id b10mr17094822wmf.83.1480265274714; Sun, 27 Nov 2016 08:47:54 -0800 (PST) Received: from localhost ([2a02:c7d:8e80:c00:4545:3b87:fec5:8e81]) by smtp.gmail.com with ESMTPSA id cl10sm57914277wjb.4.2016.11.27.08.47.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 08:47:54 -0800 (PST) Date: Sun, 27 Nov 2016 16:48:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/8] Fix test names starting with uppercase using gdb_test on a single line. Message-ID: <20161127164749.4sdm7r47f7nbe6se@localhost> References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-3-git-send-email-lgustavo@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480107244-1484-3-git-send-email-lgustavo@codesourcery.com> User-Agent: NeoMutt/20161014 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00911.txt.bz2 On Fri, Nov 25, 2016 at 02:53:58PM -0600, Luis Machado wrote: > This fixes offender testcases that have test names starting with uppercase > when using gdb_test in a single line construct. > > gdb/testsuite/ChangeLog > 2016-11-25 Luis Machado > > Fix test names starting with uppercase throughout the files. > > * gdb/testsuite/gdb.arch/i386-mpx-simple_segv.exp > * gdb/testsuite/gdb.arch/i386-mpx.exp > * gdb/testsuite/gdb.arch/i386-permbkpt.exp > * gdb/testsuite/gdb.arch/pa-nullify.exp > * gdb/testsuite/gdb.arch/powerpc-d128-regs.exp > * gdb/testsuite/gdb.arch/vsx-regs.exp > * gdb/testsuite/gdb.base/bfp-test.exp > * gdb/testsuite/gdb.base/break.exp > * gdb/testsuite/gdb.base/breakpoint-shadow.exp > * gdb/testsuite/gdb.base/callfuncs.exp > * gdb/testsuite/gdb.base/charset.exp > * gdb/testsuite/gdb.base/commands.exp > * gdb/testsuite/gdb.base/completion.exp > * gdb/testsuite/gdb.base/dfp-test.exp > * gdb/testsuite/gdb.base/echo.exp > * gdb/testsuite/gdb.base/ending-run.exp > * gdb/testsuite/gdb.base/eval.exp > * gdb/testsuite/gdb.base/expand-psymtabs.exp > * gdb/testsuite/gdb.base/float128.exp > * gdb/testsuite/gdb.base/floatn.exp > * gdb/testsuite/gdb.base/foll-exec-mode.exp > * gdb/testsuite/gdb.base/gdb1056.exp > * gdb/testsuite/gdb.base/gdb11531.exp > * gdb/testsuite/gdb.base/kill-after-signal.exp > * gdb/testsuite/gdb.base/multi-forks.exp > * gdb/testsuite/gdb.base/overlays.exp > * gdb/testsuite/gdb.base/pending.exp > * gdb/testsuite/gdb.base/sepdebug.exp > * gdb/testsuite/gdb.base/testenv.exp > * gdb/testsuite/gdb.base/valgrind-db-attach.exp > * gdb/testsuite/gdb.base/watch_thread_num.exp > * gdb/testsuite/gdb.base/watchpoint-cond-gone.exp > * gdb/testsuite/gdb.base/watchpoint.exp > * gdb/testsuite/gdb.base/watchpoints.exp > * gdb/testsuite/gdb.cp/arg-reference.exp > * gdb/testsuite/gdb.cp/baseenum.exp > * gdb/testsuite/gdb.cp/operator.exp > * gdb/testsuite/gdb.cp/shadow.exp > * gdb/testsuite/gdb.dwarf2/dw2-op-out-param.exp > * gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp > * gdb/testsuite/gdb.go/chan.exp > * gdb/testsuite/gdb.go/hello.exp > * gdb/testsuite/gdb.go/integers.exp > * gdb/testsuite/gdb.go/methods.exp > * gdb/testsuite/gdb.go/package.exp > * gdb/testsuite/gdb.guile/scm-parameter.exp > * gdb/testsuite/gdb.guile/scm-progspace.exp > * gdb/testsuite/gdb.guile/scm-value.exp > * gdb/testsuite/gdb.mi/mi-pending.exp > * gdb/testsuite/gdb.mi/user-selected-context-sync.exp > * gdb/testsuite/gdb.multi/multi-attach.exp > * gdb/testsuite/gdb.multi/tids.exp > * gdb/testsuite/gdb.opt/clobbered-registers-O2.exp > * gdb/testsuite/gdb.pascal/floats.exp > * gdb/testsuite/gdb.pascal/integers.exp > * gdb/testsuite/gdb.python/py-block.exp > * gdb/testsuite/gdb.python/py-events.exp > * gdb/testsuite/gdb.python/py-finish-breakpoint2.exp > * gdb/testsuite/gdb.python/py-parameter.exp > * gdb/testsuite/gdb.python/py-symbol.exp > * gdb/testsuite/gdb.python/py-symtab.exp > * gdb/testsuite/gdb.python/py-type.exp > * gdb/testsuite/gdb.python/py-value.exp > * gdb/testsuite/gdb.python/py-xmethods.exp > * gdb/testsuite/gdb.python/python.exp > * gdb/testsuite/gdb.reverse/break-precsave.exp > * gdb/testsuite/gdb.reverse/consecutive-precsave.exp > * gdb/testsuite/gdb.reverse/finish-precsave.exp > * gdb/testsuite/gdb.reverse/i386-precsave.exp > * gdb/testsuite/gdb.reverse/machinestate-precsave.exp > * gdb/testsuite/gdb.reverse/sigall-precsave.exp > * gdb/testsuite/gdb.reverse/solib-precsave.exp > * gdb/testsuite/gdb.reverse/step-precsave.exp > * gdb/testsuite/gdb.reverse/until-precsave.exp > * gdb/testsuite/gdb.reverse/watch-precsave.exp > * gdb/testsuite/gdb.server/ext-attach.exp > * gdb/testsuite/gdb.server/ext-restart.exp > * gdb/testsuite/gdb.server/ext-run.exp > * gdb/testsuite/gdb.server/ext-wrapper.exp > * gdb/testsuite/gdb.stabs/gdb11479.exp > * gdb/testsuite/gdb.stabs/weird.exp > * gdb/testsuite/gdb.threads/attach-many-short-lived-threads.exp > * gdb/testsuite/gdb.threads/kill.exp > * gdb/testsuite/gdb.threads/watchpoint-fork.exp Drop "gdb/testsuite/". > # test break at line number in file > @@ -670,7 +670,7 @@ proc test_next_with_recursion {} { > global decimal > global binfile > > - gdb_test "kill" "" "kill program" "Kill the program being debugged.*y or n. $" "y" > + gdb_test "kill" "" "kill program" "kill the program being debugged.*y or n. $" "y" "Kill the program" is to be matched to the output of GDB, so this change is not needed. There are some instances of this problem in this patch. > delete_breakpoints > > gdb_test "break factorial" "Breakpoint $decimal at .*" "break at factorial" > > diff --git a/gdb/testsuite/gdb.base/kill-after-signal.exp b/gdb/testsuite/gdb.base/kill-after-signal.exp > index 4181bec..69b27e7 100644 > --- a/gdb/testsuite/gdb.base/kill-after-signal.exp > +++ b/gdb/testsuite/gdb.base/kill-after-signal.exp > @@ -37,4 +37,4 @@ if ![runto_main] { > > gdb_test "continue" "Program received signal SIGUSR1, .*" > gdb_test "stepi" "\r\nhandler .*" > -gdb_test "kill" "^y" "kill" "Kill the program being debugged\\? \\(y or n\\) $" "y" > +gdb_test "kill" "^y" "kill" "kill the program being debugged\\? \\(y or n\\) $" "y" Likewise. > # test break at function in file > @@ -480,7 +480,7 @@ proc test_next_with_recursion {} { > global decimal > global binfile > > - gdb_test "kill" "" "kill program" "Kill the program being debugged.*y or n. $" "y" > + gdb_test "kill" "" "kill program" "kill the program being debugged.*y or n. $" "y" > delete_breakpoints > Likewise. > # Explicitly kill the program so it doesn't dump core when we quit->detach. > -gdb_test "kill" "" "kill program" "Kill the program being debugged.*y or n. $" "y" > +gdb_test "kill" "" "kill program" "kill the program being debugged.*y or n. $" "y" Likewise. > -gdb_test "kill" "" "kill inferior 2" "Kill the program being debugged.*" "y" > +gdb_test "kill" "" "kill inferior 2" "kill the program being debugged.*" "y" > gdb_test "inferior 1" ".*Switching to inferior 1.*" > -gdb_test "kill" "" "kill inferior 1" "Kill the program being debugged.*" "y" > +gdb_test "kill" "" "kill inferior 1" "kill the program being debugged.*" "y" Likewise. > kill_wait_spawned_process $test_spawn_id1 > kill_wait_spawned_process $test_spawn_id2 > diff --git a/gdb/testsuite/gdb.multi/tids.exp b/gdb/testsuite/gdb.multi/tids.exp > index 12ce98a..4808b0d 100644 > --- a/gdb/testsuite/gdb.multi/tids.exp > +++ b/gdb/testsuite/gdb.multi/tids.exp > @@ -409,7 +409,7 @@ if { ![skip_python_tests] } { > # Remove the second inferior and confirm that GDB goes back to showing > # single-number thread IDs. > with_test_prefix "back to one inferior" { > - gdb_test "kill inferior 2" "" "kill inferior 2" "Kill the program being debugged.*" "y" > + gdb_test "kill inferior 2" "" "kill inferior 2" "kill the program being debugged.*" "y" > gdb_test "thread 1.1" "Switching to thread 1\.1 .*" > gdb_test "remove-inferior 2" ".*" "remove inferior 2" > Likewise. > -gdb_test "continue" ".*exception did not finish.*" "FinishBreakpoint with exception thrown not caught" > +gdb_test "continue" ".*exception did not finish.*" "finishBreakpoint with exception thrown not caught" FinishBreakpoint should be kept as-is, IMO, or we can rewrite the message like "exception thrown not caught". > diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.server/ext-restart.exp > index b21c7c5..035686c 100644 > --- a/gdb/testsuite/gdb.server/ext-restart.exp > +++ b/gdb/testsuite/gdb.server/ext-restart.exp > @@ -60,6 +60,6 @@ with_test_prefix "restart" { > } > } > > -gdb_test "kill" "" "kill" "Kill the program being debugged.*" "y" > +gdb_test "kill" "" "kill" "kill the program being debugged.*" "y" > Likewise. > --- a/gdb/testsuite/gdb.server/ext-wrapper.exp > +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp > @@ -65,6 +65,6 @@ with_test_prefix "restart" { > gdb_test "print d" "\\$${decimal} = ${hex} \"1\".*" > } > > -gdb_test "kill" "" "kill" "Kill the program being debugged.*" "y" > +gdb_test "kill" "" "kill" "kill the program being debugged.*" "y" > > gdb_test "detach" "Detaching from.*" > } else { > - gdb_test "kill" "" "kill process" "Kill the program being debugged.*y or n. $" "y" > + gdb_test "kill" "" "kill process" "kill the program being debugged.*y or n. $" "y" > } > > gdb_test_no_output "set breakpoint always-inserted off" > diff --git a/gdb/testsuite/gdb.threads/kill.exp b/gdb/testsuite/gdb.threads/kill.exp > index a6d8382..bc00914 100644 > --- a/gdb/testsuite/gdb.threads/kill.exp > +++ b/gdb/testsuite/gdb.threads/kill.exp > @@ -68,7 +68,7 @@ proc test {threaded} { > # > # the above would mean that the remote end crashed. > > - gdb_test "kill" "^y" "kill program" "Kill the program being debugged\\? \\(y or n\\) $" "y" > + gdb_test "kill" "^y" "kill program" "kill the program being debugged\\? \\(y or n\\) $" "y" > } > } > Otherwise, patch is good to me. -- Yao