From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34519 invoked by alias); 27 Nov 2016 06:42:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6768 invoked by uid 89); 27 Nov 2016 06:40:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:465 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 Nov 2016 06:40:55 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 1976A341134; Sun, 27 Nov 2016 06:40:53 +0000 (UTC) Date: Sun, 27 Nov 2016 06:42:00 -0000 From: Mike Frysinger To: Stafford Horne Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org, Franck Jullien Subject: Re: [PATCH v2 1/4] gdb: Add tdesc_find_register functions Message-ID: <20161127064052.GV21655@vapier.lan> Mail-Followup-To: Stafford Horne , gdb-patches@sourceware.org, openrisc@lists.librecores.org, Franck Jullien References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KYiQozSDGNqzVCz3" Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00909.txt.bz2 --KYiQozSDGNqzVCz3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 416 On 27 Nov 2016 15:16, Stafford Horne wrote: > +/* Search FEATURE for a register REGNO and return its name. */ GNU style puts two spaces after periods > +char * > +tdesc_find_register_name (const struct tdesc_feature *feature, > + int regno) > +char * > +tdesc_find_register_group_name (const struct tdesc_feature *feature, > + int regno) seems like return values for both of these should be const -mike --KYiQozSDGNqzVCz3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYOn/0AAoJEEFjO5/oN/WBirAQAI5M9V5hO3NpbnkAlAmftLOL IGmeee21aTmxWJedrZZa3Uz9H7zqF22QufhtKeczLMSB8cWBPAVffEb7mjWGmN2A UnttnFu7++BP2//0bMYsNF0ryeQdy2pdNCTsWp0C86hVS5QYTB55eQvFZNGf4FCm +dLzidufpj9sGwJMVVkCoqiZlEKI3T+oHuUYSz2+01MaRT2jpQ1qQSwZ+PlhPtSs FDO0anWOdCI+rjjualomxgAMYn67h7MYQXgTQdBjTWSOoGjPgJmLrHrhNBLOadEz nw/VRUGgB6LIa8UaSbTgPy5AoZnNUZTpcNjEiXLMCmiU1Mn9jvUVUSSmVo+6d5b0 8nL2faEIVB3WvglBoSwR7WO/wbVRRFd4XiFK7WnxyVebwHLMXRewYsR0XBzVZLHj qNTmKZgbcwhVstGn1ierBtS/tydsHizNaq3lp8gdJ8/ERY5z3zcqm2CcrBHeaoEj hvzyawIYU8TqawrHwwnanGudzuy9/xM/DRrej08eRvyxjV0CJ5MKQcHbGsFcj+R6 +UrL1QwHXrCL5UhAw6dVOq/+fhrcFocdHx3LmboSnCQFLU+2JJiGrdDW68JJaOqq K2m7wW20XcaEoTmoYq1Ndjg1P37V3ldAZWSaytSFm1jPRgqFZ198Bmj5cxfXR+FY /2pF25plvNfMta/f5Wvz =yUYY -----END PGP SIGNATURE----- --KYiQozSDGNqzVCz3--