From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31138 invoked by alias); 25 Nov 2016 12:10:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31117 invoked by uid 89); 25 Nov 2016 12:10:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy=30pm X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 12:10:10 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAPC9H4p098906 for ; Fri, 25 Nov 2016 07:10:09 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 26xg53dhaf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 25 Nov 2016 07:10:09 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Nov 2016 12:10:07 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 25 Nov 2016 12:10:04 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id DD6A717D805A for ; Fri, 25 Nov 2016 12:12:32 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAPCA4ZH52559946 for ; Fri, 25 Nov 2016 12:10:04 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAPCA3YN008253 for ; Fri, 25 Nov 2016 05:10:04 -0700 Received: from oc8523832656.ibm.com (icon-9-167-232-32.megacenter.de.ibm.com [9.167.232.32]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uAPCA3eT008249; Fri, 25 Nov 2016 05:10:03 -0700 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 2CF3910BCB8; Fri, 25 Nov 2016 13:10:02 +0100 (CET) Subject: Re: [PATCH 2/3] Adjust Value.location for lval_register To: qiyaoltc@gmail.com (Yao Qi) Date: Fri, 25 Nov 2016 12:10:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20161125115744.GA22209@E107787-LIN> from "Yao Qi" at Nov 25, 2016 11:57:44 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112512-0008-0000-0000-000003B1A358 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112512-0009-0000-0000-00001B8DFED8 Message-Id: <20161125121002.2CF3910BCB8@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611250214 X-SW-Source: 2016-11/txt/msg00802.txt.bz2 > On Fri, Nov 25, 2016 at 12:51:30PM +0100, Ulrich Weigand wrote: > > > > > > > /* Describes offset of a value within lval of a structure in target > > > addressable memory units. If lval == lval_memory, this is an offset to > > > - the address. If lval == lval_register, this is a further offset from > > > - location.address within the registers structure. Note also the member > > > - embedded_offset below. */ > > > + the address. Note also the member embedded_offset below. */ > > > LONGEST offset; > > > > Hmm, I think we recently had the discussion that *any* values should allow > > using an offset. The comment should probably reflect this. > > > > How about "Describes offset of a value within lval of a structure. Note > also the member embedded_offset below."? I think we should leave in the "in target addressable memory units" to clarify that this is a *byte* offset, not a bit offset. Otherwise, looks good to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com