From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2020 invoked by alias); 25 Nov 2016 11:57:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1846 invoked by uid 89); 25 Nov 2016 11:57:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=30pm, H*u:2010-09-15, H*u:1.5.21, H*UA:2010-09-15 X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 11:57:55 +0000 Received: by mail-wm0-f47.google.com with SMTP id u144so27153748wmu.1 for ; Fri, 25 Nov 2016 03:57:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5IpurCF+yen81VpOnIdkWyL6AooxDEG3rpjVhqS7Xdg=; b=Q6xhvhUD/zSixGZHtNUicBJzdKJM1bXPDp9i9Y8oxv879Jl4X/rOCUoj/ZcqL+kjpk DmPlPGOqF/Q3ttanWUid6xZTHr0fi3YicDtFr4AAch+Hlr7797wDsGP0LGCwB+KUnEzB GCVfy2QteNGtDz4TwViOtnyaxFF5MtoN2slPwASBnhypY+ENK5Zm0itggiC8VYML00h/ hUMa26OlfNHih4DDk4p0dPQc0RAB8gglXpckEpSRBeCsiPZ4kvvdDFbtpFOOoeESZW/z OBmfhrkb8OAFnazwaowl6z/HmcpljtMe6CdsGwmORmsfeArL1FLsUqzYjxkQmXF+CiU6 T8rQ== X-Gm-Message-State: AKaTC014DmXsfOm88opcdxr5X8QklLw3jAl3f4gNE3F9hz19NRlTYS6dQQ3Re7U6pePLYQ== X-Received: by 10.28.51.141 with SMTP id z135mr6908023wmz.109.1480075072967; Fri, 25 Nov 2016 03:57:52 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id e6sm46646980wjw.33.2016.11.25.03.57.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 25 Nov 2016 03:57:52 -0800 (PST) Date: Fri, 25 Nov 2016 11:57:00 -0000 From: Yao Qi To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Adjust Value.location for lval_register Message-ID: <20161125115744.GA22209@E107787-LIN> References: <1480068407-22616-3-git-send-email-yao.qi@linaro.org> <20161125115130.6A33D10BCB8@oc8523832656.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161125115130.6A33D10BCB8@oc8523832656.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00801.txt.bz2 On Fri, Nov 25, 2016 at 12:51:30PM +0100, Ulrich Weigand wrote: > > > > /* Describes offset of a value within lval of a structure in target > > addressable memory units. If lval == lval_memory, this is an offset to > > - the address. If lval == lval_register, this is a further offset from > > - location.address within the registers structure. Note also the member > > - embedded_offset below. */ > > + the address. Note also the member embedded_offset below. */ > > LONGEST offset; > > Hmm, I think we recently had the discussion that *any* values should allow > using an offset. The comment should probably reflect this. > How about "Describes offset of a value within lval of a structure. Note also the member embedded_offset below."? -- Yao (齐尧)