From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112084 invoked by alias); 25 Nov 2016 11:52:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112032 invoked by uid 89); 25 Nov 2016 11:52:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:698 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 11:52:19 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAPBnF4Y135302 for ; Fri, 25 Nov 2016 06:52:18 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 26xg61casn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 25 Nov 2016 06:52:18 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Nov 2016 11:52:16 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 25 Nov 2016 11:52:12 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id D139B17D8067 for ; Fri, 25 Nov 2016 11:54:40 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAPBqCKg40239300 for ; Fri, 25 Nov 2016 11:52:12 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAPBqBeB004747 for ; Fri, 25 Nov 2016 04:52:11 -0700 Received: from oc8523832656.ibm.com (icon-9-167-232-32.megacenter.de.ibm.com [9.167.232.32]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uAPBqB9F004744; Fri, 25 Nov 2016 04:52:11 -0700 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 2CCF310BCB8; Fri, 25 Nov 2016 12:52:10 +0100 (CET) Subject: Re: [PATCH 3/3] Restrict checking value.lval on using address To: qiyaoltc@gmail.com (Yao Qi) Date: Fri, 25 Nov 2016 11:52:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1480068407-22616-4-git-send-email-yao.qi@linaro.org> from "Yao Qi" at Nov 25, 2016 10:06:47 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112511-0020-0000-0000-0000023A9E1F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112511-0021-0000-0000-00001E71F5A5 Message-Id: <20161125115210.2CCF310BCB8@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611250208 X-SW-Source: 2016-11/txt/msg00800.txt.bz2 Yao Qi wrote: > * ada-lang.c (ensure_lval): Call set_value_address after setting > VALUE_LVAL. > * elfread.c (elf_gnu_ifunc_resolve_addr): Set VALUE_LVAL to > lval_memory. > (elf_gnu_ifunc_resolver_return_stop): Likewise. > * value.c (value_fn_field): Likewise. > (value_from_contents_and_address_unresolved): Likewise. > (value_from_contents_and_address): Likewise. > (value_address): Check value->lval isn't > lval_memory. > (value_raw_address): Likewise. > (set_value_address): Assert value->lval is lval_memory. Looks good to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com