From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42606 invoked by alias); 24 Nov 2016 15:36:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42480 invoked by uid 89); 24 Nov 2016 15:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_50,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:cable-1, H*RU:sk:cable-1, H*r:sk:cable-1, uiout X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 15:36:56 +0000 X-ASG-Debug-ID: 1480001072-0c856e65d5b89c80001-fS2M51 Received: from smtp.electronicbox.net (smtp.electronicbox.net [96.127.255.82]) by barracuda.ebox.ca with ESMTP id fXmmfM8M65014GlB (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Nov 2016 10:24:32 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.lan (cable-11.246.173-162.electronicbox.net [173.246.11.162]) by smtp.electronicbox.net (Postfix) with ESMTP id 02085440E7D; Thu, 24 Nov 2016 10:24:31 -0500 (EST) From: Simon Marchi X-Barracuda-Effective-Source-IP: cable-11.246.173-162.electronicbox.net[173.246.11.162] X-Barracuda-Apparent-Source-IP: 173.246.11.162 X-Barracuda-RBL-IP: 173.246.11.162 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 05/22] Constify wrap_here/wrap_hint code path Date: Thu, 24 Nov 2016 15:36:00 -0000 X-ASG-Orig-Subj: [PATCH 05/22] Constify wrap_here/wrap_hint code path Message-Id: <20161124152428.24725-6-simon.marchi@polymtl.ca> In-Reply-To: <20161124152428.24725-1-simon.marchi@polymtl.ca> References: <20161124152428.24725-1-simon.marchi@polymtl.ca> X-Barracuda-Connect: smtp.electronicbox.net[96.127.255.82] X-Barracuda-Start-Time: 1480001072 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 5229 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.34709 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00763.txt.bz2 Constify the data path between ui_out_wrap_hint and the wrap_indent global, because we can. It's clearer that the argument passed to wrap_hint is not intended to be modified by the ui_out implementation. gdb/ChangeLog: * mi/mi-out.c (mi_wrap_hint): Constify argument. * cli-out.c (cli_wrap_hint): Likewise. * ui-out.c (ui_out_wrap_hint, uo_wrap_hint): Likewise. * ui-out.h (ui_out_wrap_hint, wrap_hint_ftype): Likewise. * utils.c (wrap_here): Likewise. (wrap_indent): Constify. * utils.h (wrap_here): Constify argument. --- gdb/cli-out.c | 2 +- gdb/mi/mi-out.c | 4 ++-- gdb/ui-out.c | 6 +++--- gdb/ui-out.h | 4 ++-- gdb/utils.c | 4 ++-- gdb/utils.h | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/cli-out.c b/gdb/cli-out.c index 0c982cb..d208207 100644 --- a/gdb/cli-out.c +++ b/gdb/cli-out.c @@ -290,7 +290,7 @@ cli_message (struct ui_out *uiout, int verbosity, } static void -cli_wrap_hint (struct ui_out *uiout, char *identstring) +cli_wrap_hint (struct ui_out *uiout, const char *identstring) { cli_out_data *data = (cli_out_data *) ui_out_data (uiout); diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c index 0f48426..960529c 100644 --- a/gdb/mi/mi-out.c +++ b/gdb/mi/mi-out.c @@ -65,7 +65,7 @@ static void mi_text (struct ui_out *uiout, const char *string); static void mi_message (struct ui_out *uiout, int verbosity, const char *format, va_list args) ATTRIBUTE_PRINTF (3, 0); -static void mi_wrap_hint (struct ui_out *uiout, char *identstring); +static void mi_wrap_hint (struct ui_out *uiout, const char *identstring); static void mi_flush (struct ui_out *uiout); static int mi_redirect (struct ui_out *uiout, struct ui_file *outstream); @@ -273,7 +273,7 @@ mi_message (struct ui_out *uiout, int verbosity, } void -mi_wrap_hint (struct ui_out *uiout, char *identstring) +mi_wrap_hint (struct ui_out *uiout, const char *identstring) { wrap_here (identstring); } diff --git a/gdb/ui-out.c b/gdb/ui-out.c index a7fdcd0..840254d 100644 --- a/gdb/ui-out.c +++ b/gdb/ui-out.c @@ -174,7 +174,7 @@ static void uo_text (struct ui_out *uiout, const char *string); static void uo_message (struct ui_out *uiout, int verbosity, const char *format, va_list args) ATTRIBUTE_PRINTF (3, 0); -static void uo_wrap_hint (struct ui_out *uiout, char *identstring); +static void uo_wrap_hint (struct ui_out *uiout, const char *identstring); static void uo_flush (struct ui_out *uiout); static int uo_redirect (struct ui_out *uiout, struct ui_file *outstream); @@ -507,7 +507,7 @@ ui_out_message (struct ui_out *uiout, int verbosity, } void -ui_out_wrap_hint (struct ui_out *uiout, char *identstring) +ui_out_wrap_hint (struct ui_out *uiout, const char *identstring) { uo_wrap_hint (uiout, identstring); } @@ -685,7 +685,7 @@ uo_message (struct ui_out *uiout, int verbosity, } void -uo_wrap_hint (struct ui_out *uiout, char *identstring) +uo_wrap_hint (struct ui_out *uiout, const char *identstring) { if (!uiout->impl->wrap_hint) return; diff --git a/gdb/ui-out.h b/gdb/ui-out.h index a76dfe8..1865765 100644 --- a/gdb/ui-out.h +++ b/gdb/ui-out.h @@ -123,7 +123,7 @@ extern void ui_out_message (struct ui_out *uiout, int verbosity, const char *format, ...) ATTRIBUTE_PRINTF (3, 4); -extern void ui_out_wrap_hint (struct ui_out *uiout, char *identstring); +extern void ui_out_wrap_hint (struct ui_out *uiout, const char *identstring); extern void ui_out_flush (struct ui_out *uiout); @@ -186,7 +186,7 @@ typedef void (text_ftype) (struct ui_out * uiout, typedef void (message_ftype) (struct ui_out * uiout, int verbosity, const char *format, va_list args) ATTRIBUTE_FPTR_PRINTF(3,0); -typedef void (wrap_hint_ftype) (struct ui_out * uiout, char *identstring); +typedef void (wrap_hint_ftype) (struct ui_out * uiout, const char *identstring); typedef void (flush_ftype) (struct ui_out * uiout); typedef int (redirect_ftype) (struct ui_out * uiout, struct ui_file * outstream); diff --git a/gdb/utils.c b/gdb/utils.c index 8ca0a2e..3a88e2a 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1628,7 +1628,7 @@ static char *wrap_pointer; /* String to indent by if the wrap occurs. Must not be NULL if wrap_column is non-zero. */ -static char *wrap_indent; +static const char *wrap_indent; /* Column number on the screen where wrap_buffer begins, or 0 if wrapping is not in effect. */ @@ -1911,7 +1911,7 @@ reinitialize_more_filter (void) used to force out output from the wrap_buffer. */ void -wrap_here (char *indent) +wrap_here (const char *indent) { /* This should have been allocated, but be paranoid anyway. */ if (!wrap_buffer) diff --git a/gdb/utils.h b/gdb/utils.h index 62091f0..f2fb54d 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -146,7 +146,7 @@ extern int yquery (const char *, ...) ATTRIBUTE_PRINTF (1, 2); extern void begin_line (void); -extern void wrap_here (char *); +extern void wrap_here (const char *); extern void reinitialize_more_filter (void); -- 2.10.0