Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/3] Add noexcept to custom non-throwing new operators.
Date: Wed, 23 Nov 2016 20:08:00 -0000	[thread overview]
Message-ID: <20161123200652.89209-3-jhb@FreeBSD.org> (raw)
In-Reply-To: <20161123200652.89209-1-jhb@FreeBSD.org>

Both libc++ and libstdc++ declare non-throwing new operators as
noexcept and overloads must also be noexcept.  This fixes a
-Wmissing-exception-spec warning with clang.

gdb/ChangeLog:

	* common/new-op.c (operator new): Mark 'noexcept'.
	(operator new[]): Likewise.
---
 gdb/ChangeLog       | 5 +++++
 gdb/common/new-op.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9e8fb4f..051d4ce 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2016-11-23  John Baldwin  <jhb@FreeBSD.org>
 
+	* common/new-op.c (operator new): Mark 'noexcept'.
+	(operator new[]): Likewise.
+
+2016-11-23  John Baldwin  <jhb@FreeBSD.org>
+
 	* breakpoint.h (class number_or_range_parser): Use 'class' instead of
 	'struct'.
 	* mi/mi-main.c (mi_cmd_trace_frame_collected): Use
diff --git a/gdb/common/new-op.c b/gdb/common/new-op.c
index 1eb4f94..c67239c 100644
--- a/gdb/common/new-op.c
+++ b/gdb/common/new-op.c
@@ -76,7 +76,7 @@ operator new (std::size_t sz)
 }
 
 void *
-operator new (std::size_t sz, const std::nothrow_t&)
+operator new (std::size_t sz, const std::nothrow_t&) noexcept
 {
   /* malloc (0) is unpredictable; avoid it.  */
   if (sz == 0)
@@ -91,7 +91,7 @@ operator new[] (std::size_t sz)
 }
 
 void*
-operator new[] (std::size_t sz, const std::nothrow_t&)
+operator new[] (std::size_t sz, const std::nothrow_t&) noexcept
 {
   return ::operator new (sz, std::nothrow);
 }
-- 
2.9.2


  reply	other threads:[~2016-11-23 20:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 20:07 [PATCH 0/3] Fix various C++ related clang warnings John Baldwin
2016-11-23 20:08 ` John Baldwin [this message]
2016-11-24 17:03   ` [PATCH 2/3] Add noexcept to custom non-throwing new operators Pedro Alves
2016-11-23 20:08 ` [PATCH 1/3] Fix mismatched struct vs class tags John Baldwin
2016-11-23 20:58   ` Simon Marchi
2016-11-23 23:23     ` John Baldwin
2016-11-24 17:02       ` Pedro Alves
2016-11-24 17:47         ` John Baldwin
2016-11-24 18:50           ` Pedro Alves
2016-11-24 19:15             ` John Baldwin
2016-11-30 11:39               ` Pedro Alves
2016-11-30 16:23                 ` John Baldwin
2016-11-30 16:38                   ` Pedro Alves
2016-11-30 16:52                     ` Simon Marchi
2016-11-30 16:51                   ` Simon Marchi
2016-11-30 17:08                     ` Pedro Alves
2016-11-30 17:54                       ` Simon Marchi
2016-11-30 17:59                     ` Eli Zaretskii
2016-11-23 20:08 ` [PATCH 3/3] Do not use std::move when assigning an anonymous object to a unique_ptr John Baldwin
2016-11-23 21:19   ` Simon Marchi
2016-11-23 23:31     ` John Baldwin
2016-11-24  0:08       ` Simon Marchi
2016-11-24 16:52         ` Pedro Alves
2016-11-23 22:18 ` [PATCH 0/3] Fix various C++ related clang warnings Simon Marchi
2016-11-23 23:23   ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123200652.89209-3-jhb@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox