From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79421 invoked by alias); 21 Nov 2016 20:37:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79404 invoked by uid 89); 21 Nov 2016 20:37:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 20:37:32 +0000 Received: by mail-wm0-f68.google.com with SMTP id u144so426075wmu.0 for ; Mon, 21 Nov 2016 12:37:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hs/ngxDzYqnER54FKY4KS1l4KTd0zBwe70ASLsI5IJc=; b=amQ6m0Jfr+dl4roKiSQaFIaroF+bbJMDJ1MLzepGI+77i7MVOqoThSKj9ROcFA8K7s oIb6+iREQzR2DtWeWPryqKxNiCSYGilQvi3uAuuNkazBSmdigGI6OHTTKNwzt2vDQiEm RaXhlucQFCpcY7S3bDR62zwS5RKSCZrhJ9T/cKkmrilrdLzZ/aKZgtopBaDvoBZyUtEw GpC+moPqxgirXge/xpNl/38xQ4p5yiylmZFtK8ZWGMAlYmDK7yzCDR6Lb7zZ3fCrICJr +kXvtUctNbP9203Qjfhjm37sf+quMjVYOucf8qgo7LVJgtbL1g0i2hcqwEeQ2K43hguG hOgA== X-Gm-Message-State: AKaTC03ZjDZBJUZ48n8Q3zRdfZYD1zdv/y3sJPrfTEbU/0JxIDYBQe5HoaE+/UWc+bDpIQ== X-Received: by 10.28.63.150 with SMTP id m144mr15903902wma.96.1479760650178; Mon, 21 Nov 2016 12:37:30 -0800 (PST) Received: from localhost ([2a02:c7d:8e80:c00:10ec:ccc0:d67b:db96]) by smtp.gmail.com with ESMTPSA id ia7sm26876479wjb.23.2016.11.21.12.37.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Nov 2016 12:37:29 -0800 (PST) Date: Mon, 21 Nov 2016 20:37:00 -0000 From: Yao Qi To: Ulrich Weigand Cc: user-agent@de.ibm.com, "gdb-patches@sourceware.org" , Tom Tromey Subject: Re: set_value_component_location in apply_val_pretty_printer Message-ID: <20161121203724.ttcwotysdozdzn7v@localhost> References: <20161114125143.GA22037@E107787-LIN> <20161114163832.3C14F10B924@oc8523832656.ibm.com> <20161121141428.GB28605@E107787-LIN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00615.txt.bz2 On Mon, Nov 21, 2016 at 06:23:47PM +0000, Yao Qi wrote: > I removed the code setting VALUE_NEXT_FRAME_ID, but > value_from_component only sets VALUE_FRAME_ID. The change > above is not equivalent, and it causes some regressions in > https://sourceware.org/ml/gdb-testers/2016-q4/msg03381.html > > Sorry about that. The fix would be setting both > VALUE_NEXT_FRAME_ID and VALUE_FRAME_ID in > value_from_component. I'll give a fix. > Oh, looks we renamed VALUE_FRAME_ID to VALUE_NEXT_FRAME_ID recently, https://sourceware.org/ml/gdb-patches/2016-11/msg00018.html and I regression tested against a copy of one-week-old gdb, but didn't see the regression. The fix would be replacing VALUE_FRAME_ID with VALUE_NEXT_FRAME_ID in my patch. Testing the fix... -- Yao