From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127618 invoked by alias); 16 Nov 2016 16:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127605 invoked by uid 89); 16 Nov 2016 16:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=gmo, U*$, co, PACKAGE X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 16:12:18 +0000 Received: from ESESSHC015.ericsson.se (Unknown_Domain [153.88.183.63]) by (Symantec Mail Security) with SMTP id E9.C8.02551.A458C285; Wed, 16 Nov 2016 17:11:54 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.63) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 Nov 2016 17:08:31 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.dyn.mo.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.2; Wed, 16 Nov 2016 16:08:29 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules Date: Wed, 16 Nov 2016 16:12:00 -0000 Message-ID: <20161116160808.12830-4-simon.marchi@ericsson.com> In-Reply-To: <20161116160808.12830-1-simon.marchi@ericsson.com> References: <20161116160808.12830-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: SN1PR02CA0035.namprd02.prod.outlook.com (10.165.224.173) To AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;2:Z74k1xu0ktEyqs9HOMA2Jcg91xSP3gt+X+WAZfQgdHk5vTjgx7Q1cWxqTfupUELg23QFpOUqplmwqsx7WS7ylos7lVUKo6zJfI2XYNLg4CSIeqqqGg8c2BJh6NNOvHdaw32A6BXfXhgLbvlb5k+7MGY4Tl5w8Uz2pW7Pg7xzkiM=;3:8v8dN+C915l3NIhVzfdd/YAOlKqKTvzfq+E0iBsWanHdwfrQjyVegC3ED6YnsS2xEIMAdOwrKFV/gfKZwr6+ATvcNyo+MAz3b6CuIqeoVdJhmikN3M1+NnJBIF+2HvSDeKzipZtEHDFWE4eUXrivRSnQYF9jwFPEoyNVW3oLqPU= X-MS-Office365-Filtering-Correlation-Id: 1dae17d3-c108-4daf-06b9-08d40e3ace98 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;25:F3Fc0o3eWGe54FqDk+7ouuLb9uyAVICvDXLJcV0HafShmqwv13qJaH9/CiFFKQdw98BjIXYpcmZ3esuh4CdUKa4PmsUe8/uXwbLhZ6/foSxihvNXcevPw3ZH0sTondm/rtWSYUwh1nh6T+1Oy/yzuCpYAQmjgnmseuWV/zPu1bsCG0718Ljwhmf503YuA4NlyRwIQHqYJVvBsQbs2IczWuvpSSSkQ8K2rPw04S5UBeThGqcXAfdvj0qXMR9W3YXyzq8qgMtIdVN2wtFKB5d6JCa5xTadJ3Qq+gC/nCgnpSVUFK8sP+7EpMfM//oK4ySoSIqm+suzF2cHnIDhzs4Li12hmPOWoIXvueMYVOpHrxWZWuE/Uj0rP+3lFk4Ryg/MS+5A691BKUZdqGMIWfeBkmg22yKqMqIH0EkvS5Vcvr6VLaAzLwRplzXth7i+teBENd1R/6eGum8F2Npv85k2qvxykPNhHQcVhKouT+B0hpe+ymXorlD+OiBX8fWKVvTPi5ULDtxKram63jwsM90DamXy7z1KE8Al5jWejRTzBlNYJVNKr6Ym6CWYU3zwTNLN3aggA1Ab6fU5zbGIjkyGcyjQzaIpL2ctiDOy0goyMdgYwMgm7GNt5qDYEXUtC7Oxu4U4PCq0W829U2TtAIvJPAqXhM8ktGxJAU7KVb2mla/F+lAza8WpqoFxECZwnpPUo0w1Jb7RKudHGpK6TaqtxtFUWdybXnTtandH/1SUIgZML2BqK2ZGPyvyBp/T5QukEvCrOO/fCO6EAbQ2i9MEdfvJL+xb0SF5HdyLcO5SZZkQwLy+Gm1d166CVCrgigBZeba0p4pqR6LTUPxDtRBJ6kOTQp3wS2uBWGMJoi9tNLZfOHOC9vmQ4htJVY4blemZFnGXb3yGD5k8EvPv3MEHnA== X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;31:ECsHqVJTGnwRwI1tVqSI9V0PkzjxOAzkxgAKUGFcn4nnwEIOMkFprGwx1o6SpQDvh+dhM+710D/cnyTe1Z5QyXFCtqZJ6qYijcobflCps73tXXf6zepj9TRaG/Zf0IlrrnNM5kSppznO83CFTuMlo480qdigp5r9vvIK0gpcdBd/fBn2KB3axPIvFqkocDHw4EcO2dXlsHIpo8jj5wYwiueWL2HKYD8A4UeHPVoFgUFTmWacReHunwPOxpxIU+5nMKnXVQi0onHYufU+eJVPn/zbMfkv52HxVZQouy212Ww=;20:ahdQpojjA1/PM+ntDOtLKu+5LM4+Fh6nK/v45lyjGXYZWxHn9+bTV/YNHtBAq6oKjbkkhtGJRmfPoPPD07P7ulAQS/PtbM6ymC9UWZiZs5rvPy44bovdZfs4JlAQa2xpACHnHT9zP4cHAAN+ZiDDuM/1fu5aUBWZ+toxZRWqFAORkkvtQ9UDQzC3K5A+C8XihR9EaKEweCop6c2DQ3I8d5M3Ww0cfXR/iJtH5OIaVqEEasb3B/drA9svK9XdT37T5bszsZ51wT/Dq0PTjdqZBNO6WdNYRlBxjWjL1vbTxxq8YmHklLaAoCkwSCD7blsjQUAjvB7eLlsQZ9+cKHnHO9ewplyFOfxOckFX0js4yqqRekGnd9BGnG9aEDKsTHb6k2LpafixagPvDHebjdfsAQoO19BnKirnW4fcbKjS7EgyToXO4xjE6EsZmjGZoNt8WNwccGBlc8yunPDrd/2/Y8nDYtpyIv9nRrD18kY1CbKOrk91wISUhJ2dAM0u6Kfp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040281)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041223)(6061324);SRVR:AMSPR07MB389;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;4:a19DXE7WWIJaMDmPN/9aw5t56+8fY2oG285GDQYJgxe87IwfjSLSZd+rAguXIavPmC67QufhRzSOpASsR0Ks4bxyhWhfGntgSb9QYhNvnhxhNtGH+TSqpzsA7MnL9E/EoWpNNw1fm/s8hAQzpbAQss7JCdeBAl9qN9HIp42OUVXkSxzZ7YHnaZ5yrsqVDur7T9aVtTQ0B5TDmZNGNZtbJQykEbZEnLqPZ8Rg7ux0b/9dxn6NJhiMyQW78qZ7kv12SBKUv6K1giU+75XcJYWzAf1b8tE/O/8CATRUkLudiN4cSiDX1e0WMSQSlxKb9N6rT/roqeI3ir2UmxDXJfV93epZ83Frl28HqotwqH2dYEUvXpmlLg+t0csyHB7St1izt3y9EMCU+Rg/xRk7GiPoIzbwobwZrsUj2x4kDy33tGb07kpB9kjagby5IFHOm7ywI1WZC+1diZ9gjM7/VttsJjU/9FWl9x45g5ZWxSDXWm08VURqJde0M3J+N2m1Rjn2CFGE7spDQRTqfJo1cDztjAoSzfUKPfwRtAKFjuwLzFrPvNBv1PBmukkZqZFVp/gr X-Forefront-PRVS: 01283822F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(54534003)(66066001)(81156014)(81166006)(50466002)(68736007)(2950100002)(5003940100001)(6666003)(8676002)(47776003)(189998001)(6916009)(5660300001)(4326007)(50226002)(105586002)(305945005)(50986999)(36756003)(106356001)(7846002)(92566002)(7736002)(76176999)(2351001)(48376002)(1076002)(42186005)(77096005)(101416001)(110136003)(6116002)(86362001)(3846002)(33646002)(2906002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB389;H:elxcz23q12-y4.dyn.mo.ca.am.ericsson.se;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AMSPR07MB389;23:kvc2HWfYbLoWmj07UN/21VOF2BmjP0/lMqQbds1DiO?= =?us-ascii?Q?Of524x0NGOB228gM/zrn2z1hyT/8HptkRBotwjnRyRlVz+KB011EMcm7IMSI?= =?us-ascii?Q?0JlpkvIZp+viFNCe10UnJQTMse8O9g8bIREvpXS/IynMPDIJWFl8OOM2pSfp?= =?us-ascii?Q?ULfZKAml3PWyOe90PO+ztKY+10fEBRlWFl6/Z/344d7LEdaVu984mB+gDo0f?= =?us-ascii?Q?JASXofdQPT7MGvJ+QtI0ymeisHrL0PlrteNTlKA/fV7IaP0sKKo37z0IdRCf?= =?us-ascii?Q?plc+P//AzG101kFo3qGT5tsBhPw+QXiByBVU/MMTxZFPP53iX2nzG4oDcFy3?= =?us-ascii?Q?XxGKn0RLe/hclfo1Mp8iOp5qNSN1B9uYKkL45v346KUp96j4e6k2ozf7YS9v?= =?us-ascii?Q?UMofqVhopXyGkixS3AEkx650A4Wm2Dq17mBVduPIguLzhdWs+dr19kVIxXGH?= =?us-ascii?Q?tfgqs0JG9ZVwT49pkXKFrKSW/bOPkwXdg3Q6JmHb9Nr7Vc/7/tCD/s3EfggO?= =?us-ascii?Q?fKpDFXBvg1ynYqnwzHSju96VBWiZxwl9gT82OHnee+he05Xs0K2n7oEOcuTv?= =?us-ascii?Q?ZoM5wZLxsPEHhXnp0712fZiO1QTWDraV+8S+gVN3ZPQH9/Mhz7Jl7yDw7wzW?= =?us-ascii?Q?L7j2GxX8ONy3MHPvvW7gMKiD6xZosPd9IsxPPsTpsyf8KxE+jWyIu+9nnrw+?= =?us-ascii?Q?/yt5ZndRbVcJAp/UkOMIU27b+Vb2Ph2IEstrxR4CFZtpgoKGlrOm3zN1MoOH?= =?us-ascii?Q?qBYrSqNG29i+Xh3v+qPetuSFjysKbd7PQnMrnWa7NlncpnCL34GhHYRt61Pd?= =?us-ascii?Q?AtlRvHr25l24iOLQ0kt83MayKXaGM7asB4LEp4RcoECVV7p7NQQVyda8on6x?= =?us-ascii?Q?qPAbu+zV5/mPipfHsH6nvguwj4aMRI8YRwQHfui1H/oOkEe4Wl8PQlLPDI6M?= =?us-ascii?Q?j8NKOOGp/6OviXbJV+ohyMuu4Hs7u19VPJc6jl4qK+MoIwFYl1au6JVM45M8?= =?us-ascii?Q?0VmHvt+VL41S7gZkRsD7WgYrgAcstZQEdChfXltJ3Ao6NY+PK8KaLUt1C+4E?= =?us-ascii?Q?JDPz1BMks84emxhOrpSelWYDGT?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;6:XevXyCZgzJ0ij/4UxO1yxtQRR4Fam5pwrMRKfvuRv9F2S+eKxgaEa0qY2JjlO05D3VjviOmEIay8BrVZ7Gth/fkdVtkrQEnfzoSW37oRrTUCJ2LpujCgUQWKl806Tw8+uycHVTC3RLpIVd+3+yfs3FXd4Y1iI2QH4z51w4iu5C6/Eb/8hLp17v4vlTUTu2K9aKRXKH89aDRgt7s6tDURb3MQS4Zp/guTOJ3dN7l66JJQahwfACPhYXx++ck3SRhLGq7QfcA5jT5ELMAXB1GFZ5rAYRoSHulxAzBWTKeSUIEazsaSYnztJiXuJVVacky1LU0KdmUxsRZsN3BLy4ITFAm6mTIVQa11sXagOaVsFTo=;5:0j4SRq9CczRdAdx1lqlCLAXYi9Wp9k8e1p4qQZs6z3tp7T5H1E9uXgjB1W7buxLppExtReXH6bAcpRPup4K5qASQakQswuNQJ5jYoN+osGMzJzGnZRnM1iE1wapLDOurQ0mzFzoZ75KKIKdxA1HedQ==;24:7S5Wod0cLojyq/x3af+F+Ojw7oM4zEk7H9B/cHmuU1zpDgDHob8+jlE3NORpGTBbqIZFvItsjTPVtIcHLTo4Gz17P1Tz2r1mEZ9Yd8aTvbs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;7:f34cTOOHI+AGj+HL9x59UvaOChw8EaModyGy8mZjBT5ydeKd8Q9u85eLDYqU5zBAasjB15Ix2zLbOFWS+607cxfkiMfp6yV1syaZmEdiOplcTotYVA8xC/OBBtGQTiCO1H+ocU3rERFPrsrtzswf2Llr/1us5vjLpEQBq4LXLhwM0bXaHXQQ3Ef8V8SP4Wh8vussu5UNLsRhVRHGW7GRRQTvwXho4Ru9Jey1HYWXtKJQ0fl9UDXt5DSj3zqi0l0BeuJZbut87vbpqrIjwwvKrns2RlUuUpoQY2fUfPzaSQCLXY7Ir9JIW6qhuvDqXntW9JcgqSK1SsHUMAJJAqg9RwPC+JWgurK1blXTQR/9U8Q= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 16:08:29.5708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB389 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00421.txt.bz2 From: Simon Marchi As mentioned here [1], suffix rules are obsolete and have been superseeded with pattern rules. People (myself included, before writing this patch) are more likely to know what pattern rules are than suffix rules. AFAIK, .SUFFIXES targets are only used for those rules, and can be removed as well. New in v2: - Replace rule in gdbserver/Makefile.in as well. [1] https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html gdb/ChangeLog: * Makefile.in (.c.o): Replace rule with ... (%.o: %.c): ... this one. (.po.gmo): Replace rule with ... (%.gmo: %.po): ... this one. (.po.pox): Replace rule with ... (%.pox: %.po): ... this one. (.y.c): Replace rule with ... (%.c: %.y): ... this one. (.l.c): Replace rule with ... (%.c: %.l): ... this one. (.SUFFIXES): Remove all instances. gdb/gdbserver/ChangeLog: * Makefile.in (.c.o): Replace rule with ... (%.o: %.c): ... this one. --- gdb/Makefile.in | 12 +++++------- gdb/gdbserver/Makefile.in | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index f53b121..fe10a8d 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1122,7 +1122,7 @@ DISTSTUFF = $(YYFILES) generated_files = config.h observer.h observer.inc ada-lex.c jit-reader.h \ $(GNULIB_H) $(NAT_GENERATED_FILES) gcore -.c.o: +%.o: %.c $(COMPILE) $< $(POSTCOMPILE) @@ -1801,7 +1801,6 @@ ada-exp.o: ada-exp.c # Rules for generating translated message descriptions. Disabled by # autoconf if the tools are not available. -.SUFFIXES: .po .gmo .pox .pot .PHONY: all-po install-po uninstall-po clean-po update-po $(PACKAGE).pot all-po: $(CATALOGS) @@ -1812,14 +1811,14 @@ update-po: $(CATALOGS:.gmo=.pox) # N.B. We do not attempt to copy these into $(srcdir). The snapshot # script does that. -.po.gmo: +%.gmo: %.po -test -d po || mkdir po $(GMSGFMT) --statistics -o $@ $< # The new .po has to be gone over by hand, so we deposit it into # build/po with a different extension. If build/po/$(PACKAGE).pot # exists, use it (it was just created), else use the one in srcdir. -.po.pox: +%.pox: %.po -test -d po || mkdir po $(MSGMERGE) $< `if test -f po/$(PACKAGE).pot; \ then echo po/$(PACKAGE).pot; \ @@ -1880,8 +1879,7 @@ po/$(PACKAGE).pot: force # Strictly speaking c-exp.c should therefore depend on # Makefile.in, but that was a pretty big annoyance. -.SUFFIXES: .y .l -.y.c: +%.c: %.y rm -f $@ $@.tmp $(SHELL) $(YLWRAP) $< y.tab.c $@ -- $(YACC) $(YFLAGS) && mv $@ $@.tmp \ || (rm -f $@; false) @@ -1897,7 +1895,7 @@ po/$(PACKAGE).pot: force -e 's/YY_NULL/YY_NULLPTR/g' \ < $@.tmp > $@ rm -f $@.tmp -.l.c: +%.c: %.l if [ "$(FLEX)" ] && $(FLEX) --version >/dev/null 2>&1; then \ $(FLEX) -o$@ $< && \ rm -f $@.new && \ diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index a1f4675..c25d21e 100644 --- a/gdb/gdbserver/Makefile.in +++ b/gdb/gdbserver/Makefile.in @@ -256,7 +256,7 @@ FLAGS_TO_PASS = \ # All generated files which can be included by another file. generated_files = config.h $(GNULIB_H) -.c.o: +%.o: %.c $(COMPILE) $< $(POSTCOMPILE) -- 2.10.2