From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87856 invoked by alias); 16 Nov 2016 19:08:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87336 invoked by uid 89); 16 Nov 2016 19:08:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=okd X-HELO: emailserver1.aplushosting.com Received: from emailserver1.asdf456.com (HELO emailserver1.aplushosting.com) (72.18.207.136) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 16 Nov 2016 19:08:27 +0000 Received: (qmail 30200 invoked by uid 0); 16 Nov 2016 19:08:25 -0000 Received: from unknown (HELO pinnacle.lan) (70.176.31.165) by emailserver1.asdf456.com with SMTP; Wed, 16 Nov 2016 11:08:25 -0800 Date: Wed, 16 Nov 2016 19:08:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/5] Make gdb.PendingFrame.read_register handle "user" registers Message-ID: <20161116120824.0e8718f7@pinnacle.lan> In-Reply-To: <20161102152332.29708966@pinnacle.lan> References: <20161102151111.2462c806@pinnacle.lan> <20161102152332.29708966@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00444.txt.bz2 On Wed, 2 Nov 2016 15:23:32 -0700 Kevin Buettner wrote: > [ FYI, Pedro has already OK'd this one. It's unchanged from the version > in the earlier series, but is included here for completeness. ] > > The C function, pending_framepy_read_register(), which implements > the python interface gdb.PendingFrame.read_register does not handle > the so called "user" registers like "pc". An assertion error is > triggered due to the user registers having numbers larger than or > equal to gdbarch_num_regs(gdbarch). > > With the VALUE_FRAME_ID tweak in place, the call to > get_frame_register_value() can simply be replaced by a call to > value_of_register(), which handles both real registers as well as the > user registers. > > gdb/ChangeLog: > > * python/py-unwind.c (pending_framepy_read_register): Use > value_of_register() instead of get_frame_register_value(). I've pushed this change. Kevin