From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85087 invoked by alias); 16 Nov 2016 19:07:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85050 invoked by uid 89); 16 Nov 2016 19:07:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=Hx-languages-length:1569, puzzled X-HELO: emailserver1.aplushosting.com Received: from emailserver1.asdf456.com (HELO emailserver1.aplushosting.com) (72.18.207.136) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 16 Nov 2016 19:07:18 +0000 Received: (qmail 29033 invoked by uid 0); 16 Nov 2016 19:07:17 -0000 Received: from unknown (HELO pinnacle.lan) (70.176.31.165) by emailserver1.asdf456.com with SMTP; Wed, 16 Nov 2016 11:07:17 -0800 Date: Wed, 16 Nov 2016 19:07:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 5/5] Stash frame id of current frame before stashing frame id for previous frame Message-ID: <20161116120716.253442f3@pinnacle.lan> In-Reply-To: <61313629-93ad-933c-c699-6919d90a9d80@redhat.com> References: <20161102151111.2462c806@pinnacle.lan> <20161102152601.6e79f698@pinnacle.lan> <61313629-93ad-933c-c699-6919d90a9d80@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00443.txt.bz2 On Wed, 9 Nov 2016 14:48:46 +0000 Pedro Alves wrote: > On 11/02/2016 10:26 PM, Kevin Buettner wrote: > > > I will first note that the frame id for frame has not been computed yet. (This > > was verified by placing a breakpoint on compute_frame_id().) > > > > The call to get_prev_frame() causes the the frame id to (eventually) be > > computed for the previous frame. Here's a backtrace showing how we > > get there: > > > > at gdb/frame.c:496 > > at gdb/frame.c:1871 > > at gdb/frame.c:2045 > > at gdb/frame.c:2061 > > at gdb/frame.c:2303 > > at gdb/python/py-frame.c:381 > > Function names would make that backtrace soooo much easier to read. :-) Thanks for catching this. It had me puzzled for a while. Since some of the backtrace lines were long, I pasted the backtrace into my commit message without any leading whitespace. As a consequence, the # for the backtrace ended up in column 0 and was interpreted by git as a comment. I added the backtraces back into the commit message with leading whitespace. After reading the documentation, I see that "git commit --cleanup=verbatim" could be used to prevent git from removing lines starting with #. Though that means that the committer needs to manually remove other comment lines added by git. > > > gdb/ChangeLog: > > > > * frame.c (get_prev_frame): Stash frame id for current frame > > prior to computing frame id for previous frame. > > > I'm fine with this solution. LGTM. Pushed. Kevin