From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134902-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 122415 invoked by alias); 16 Nov 2016 18:54:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 122335 invoked by uid 89); 16 Nov 2016 18:54:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=
X-HELO: emailserver1.aplushosting.com
Received: from emailserver1.asdf456.com (HELO emailserver1.aplushosting.com) (72.18.207.136) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 16 Nov 2016 18:54:56 +0000
Received: (qmail 15763 invoked by uid 0); 16 Nov 2016 18:54:55 -0000
Received: from unknown (HELO pinnacle.lan) (70.176.31.165)	by emailserver1.asdf456.com with SMTP; Wed, 16 Nov 2016 10:54:55 -0800
Date: Wed, 16 Nov 2016 18:54:00 -0000
From: Kevin Buettner <kevin@buettner.to>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/5] Distinguish sentinel frame from null frame
Message-ID: <20161116115453.33fcefe0@pinnacle.lan>
In-Reply-To: <50027813-1980-c776-61e9-0d3a34e3455b@redhat.com>
References: <20161102151111.2462c806@pinnacle.lan>	<20161102151650.644ed9f5@pinnacle.lan>	<50027813-1980-c776-61e9-0d3a34e3455b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00442.txt.bz2

On Wed, 9 Nov 2016 14:48:09 +0000
Pedro Alves <palves@redhat.com> wrote:

> On 11/02/2016 10:16 PM, Kevin Buettner wrote:
> 
> > --- a/gdb/frame.h
> > +++ b/gdb/frame.h
> > @@ -90,6 +90,9 @@ enum frame_id_stack_status
> >    /* Stack address is valid, and is found in the stack_addr field.  */
> >    FID_STACK_VALID = 1,
> >  
> > +  /* Sentinel frame.  Stack may or may not be valid.  */
> > +  FID_STACK_SENTINEL = 2,  
> 
> What does this "Stack may or may not be valid" comment mean?
> "sentinel_frame_id" is a constant, how can the "stack_addr" field
> vary?

I've adjusted the comment as follows:

+  /* Sentinel frame.  */
+  FID_STACK_SENTINEL = 2,

> Otherwise LGTM.

Pushed.

Thanks for the review.

Kevin