From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113430 invoked by alias); 3 Nov 2016 16:41:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113366 invoked by uid 89); 3 Nov 2016 16:41:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*amodra X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 16:41:33 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA3GcnLT042033 for ; Thu, 3 Nov 2016 12:41:32 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0a-001b2d01.pphosted.com with ESMTP id 26g3g9yvx4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 03 Nov 2016 12:41:31 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Nov 2016 16:41:29 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 3 Nov 2016 16:41:26 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id AC2571B08069; Thu, 3 Nov 2016 16:43:36 +0000 (GMT) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA3GfQCf37552244; Thu, 3 Nov 2016 16:41:26 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uA3GfPFt006981; Thu, 3 Nov 2016 12:41:26 -0400 Received: from oc8523832656.ibm.com (dyn-9-152-213-198.boeblingen.de.ibm.com [9.152.213.198]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uA3GfPiT006978; Thu, 3 Nov 2016 12:41:25 -0400 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 707991032A1; Thu, 3 Nov 2016 17:41:25 +0100 (CET) Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER. To: bergner@vnet.ibm.com (Peter Bergner) Date: Thu, 03 Nov 2016 16:41:00 -0000 From: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), amodra@gmail.com (Alan Modra), gdb-patches@sourceware.org, binutils@sourceware.org (binutils) In-Reply-To: <25f99efc-6ff0-3908-dbab-fe3792be770f@vnet.ibm.com> from "Peter Bergner" at Nov 03, 2016 10:02:19 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110316-0032-0000-0000-000002368FA1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110316-0033-0000-0000-00001D8E78E6 Message-Id: <20161103164125.707991032A1@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-03_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611030308 X-SW-Source: 2016-11/txt/msg00060.txt.bz2 Peter Bergner wrote: > On 11/3/16 6:01 AM, Pedro Alves wrote: > > On 10/28/2016 03:53 PM, Peter Bergner wrote: > > BTW, I'm also not sure about saying "default" in "show disassembler-options". > > I don't think "set disassembler-options default" would work? > > Do we still need that given the option is no longer described in > > terms of cpus? > > Uli and I discussed this here: > > https://sourceware.org/ml/gdb-patches/2016-10/msg00184.html > https://sourceware.org/ml/gdb-patches/2016-10/msg00188.html > > Uli didn't like (at least the way the code was written in the earlier > patch) how I was trying to initialize the disassembler_options > to a default. He thought that just leaving disassembler_options NULL > and letting the arch choose its default was best. That's when I added > the code to emit "default" whenever disassembler_options is NULL. I think more in line with other options would be to just output the empty string if the option is not (yet) set: (gdb) show sysroot The current system root is "". (gdb) show args Argument list to give program being debugged when it is started is "". This would also match the behavior that by just using set disassembler-options without argument you can get back to that original setting. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com