From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55997 invoked by alias); 25 Oct 2016 16:25:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55987 invoked by uid 89); 25 Oct 2016 16:25:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*uweigand, Hx-languages-length:948 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 16:25:43 +0000 Received: from ball (unknown [IPv6:2607:f0c8:8000:80e0:56ee:75ff:fe52:afb9]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id B93ABC056; Tue, 25 Oct 2016 16:25:40 +0000 (UTC) Date: Tue, 25 Oct 2016 16:25:00 -0000 From: Trevor Saunders To: Pedro Alves Cc: Tom Tromey , Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual Message-ID: <20161025154131.ilwqo5p5iazfrzqq@ball> References: <20161024122802.AE37B11C284@oc8523832656.ibm.com> <87y41damyl.fsf@tromey.com> <871sz4a6co.fsf@tromey.com> <09e0354b-b0cf-11e9-de81-05cd77349805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09e0354b-b0cf-11e9-de81-05cd77349805@redhat.com> User-Agent: NeoMutt/20161014 (1.7.1) X-SW-Source: 2016-10/txt/msg00704.txt.bz2 On Tue, Oct 25, 2016 at 03:04:57PM +0100, Pedro Alves wrote: > On 10/25/2016 02:47 PM, Tom Tromey wrote: > >>>>>> "Pedro" == Pedro Alves writes: > > > > Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall > > Pedro> at some point. > > > > Perhaps it's worth adding it explicitly in configure.ac. > > (Though I don't know why it was removed from -Wall, so maybe it's not > > always appropriate, for reasons I don't know.) > > Yeah, cross my mind too. I'd like to understand why it was > removed first. (I don't know whether it used to be in -Wall, or > default, or enabled along some other -Wfoo option.) with g++ 6 I'm seeing -Wdelete-non-virtual-dtor enabled by -Wall, which seems to be warning about the same thing? oh, accept -wdelete-non-virtual-dtor looks like it wouldn't warn if the class is always on the stack like it is here. Trev