From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116746 invoked by alias); 8 Oct 2016 14:39:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116727 invoked by uid 89); 8 Oct 2016 14:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Oct 2016 14:39:51 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u98EcWms034813 for ; Sat, 8 Oct 2016 10:39:50 -0400 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 25xwb12tm0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 08 Oct 2016 10:39:49 -0400 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 8 Oct 2016 15:39:47 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp06.uk.ibm.com (192.168.101.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sat, 8 Oct 2016 15:39:46 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3C6D417D8056; Sat, 8 Oct 2016 15:41:52 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u98Edj8e63766738; Sat, 8 Oct 2016 14:39:45 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u98Edjvb010997; Sat, 8 Oct 2016 08:39:45 -0600 Received: from oc8523832656.ibm.com (icon-9-167-238-57.megacenter.de.ibm.com [9.167.238.57]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u98Edi0P010994; Sat, 8 Oct 2016 08:39:44 -0600 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 7FD3A10BEE3; Sat, 8 Oct 2016 16:39:43 +0200 (CEST) Subject: Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER. To: bergner@vnet.ibm.com (Peter Bergner) Date: Sat, 08 Oct 2016 14:39:00 -0000 From: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), amodra@gmail.com (Alan Modra), gdb-patches@sourceware.org, binutils@sourceware.org (binutils) In-Reply-To: <4b819398-85fd-3e91-01cf-dc622b38226b@vnet.ibm.com> from "Peter Bergner" at Oct 07, 2016 04:01:25 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16100814-0024-0000-0000-0000022EFBF5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16100814-0025-0000-0000-000020B62D43 Message-Id: <20161008143943.7FD3A10BEE3@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610080257 X-SW-Source: 2016-10/txt/msg00188.txt.bz2 Peter Bergner wrote: > >> + gdb_disassembler_cpu = strdup (PPC_DEFAULT_CPU",any"); > > > > Why do we have to know about this here in GDB? Can't the GDB default just > > be the empty (or NULL) string, and then opcodes does the defaulting > > (as it does today)? > > I thought it would be useful if the user does a "show powerpc disassembler" > without ever doing a "set powerpc disassembler " to show them what > default cpu they're actually using. If you want this hunk removed, I > can spit out 'default' in the case gdb_disassembler_cpu is NULL. Yes, I think this would be better. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com