From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [testsuite patch] Fix recent GCC FAIL: gdb.arch/i386-signal.exp
Date: Tue, 04 Oct 2016 16:39:00 -0000 [thread overview]
Message-ID: <20161004163944.GA8002@host1.jankratochvil.net> (raw)
In-Reply-To: <20161004161900.GA6231@host1.jankratochvil.net>
On Tue, 04 Oct 2016 18:19:00 +0200, Jan Kratochvil wrote:
> On Tue, 04 Oct 2016 18:07:56 +0200, Yao Qi wrote:
> > > The .c patch will properly create a new corresponding source line .debug_line
> > > entry for the 'mov $0x0,%eax' instruction and I also do not think it is
> > > relevant to the purpose of this testfile.
> >
> > Why do we need the second one?
>
> I find it more cleaner but that is up to you.
To make that my reason more explanatory - given the testcase expected output
is affected by that missing "return 0;" and its .debug_line record I find it
more clear for this testcase to put there the source line "return 0;"
explicitly than to depend on such implicit line by compiler as then the debug
info is unclear for that line - even among different compilers.
Jan
next prev parent reply other threads:[~2016-10-04 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 20:35 Jan Kratochvil
2016-10-04 16:08 ` Yao Qi
2016-10-04 16:19 ` Jan Kratochvil
2016-10-04 16:39 ` Jan Kratochvil [this message]
2016-10-05 8:15 ` Yao Qi
2016-10-05 19:59 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004163944.GA8002@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox