From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19571 invoked by alias); 29 Sep 2016 08:59:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19553 invoked by uid 89); 29 Sep 2016 08:59:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Sep 2016 08:59:11 +0000 Received: from ball (fanzine.igalia.com [91.117.99.155]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 3BB67C06B; Thu, 29 Sep 2016 08:59:09 +0000 (UTC) Date: Thu, 29 Sep 2016 09:19:00 -0000 From: Trevor Saunders To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 07/22] Change scoped_minimal_symbol_reader to store objfile Message-ID: <20160929090743.4i44bg6egfflvkbe@ball> References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-8-git-send-email-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474949330-4307-8-git-send-email-tom@tromey.com> User-Agent: NeoMutt/20160910 (1.7.0) X-SW-Source: 2016-09/txt/msg00409.txt.bz2 > Currently, minimal symbol table creation is not reentrant; it > relies on global (static) variables in minsyms.c. */ > > - explicit scoped_minimal_symbol_reader (); > + explicit scoped_minimal_symbol_reader (struct objfile *); C++ doesn't require the explicit struct / union when refering to the type, though of course you can keep them if you think it makes something clearer. > @@ -79,6 +79,8 @@ class scoped_minimal_symbol_reader > scoped_minimal_symbol_reader &operator= > (const scoped_minimal_symbol_reader &); > scoped_minimal_symbol_reader (const scoped_minimal_symbol_reader &); > + > + struct objfile *objfile; fwiw gcc convention is to prefix members with m_, so doing so in gdb as well would be nice. Trev