From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8165 invoked by alias); 20 Sep 2016 16:41:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8148 invoked by uid 89); 20 Sep 2016 16:41:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Sep 2016 16:41:42 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93E771B9907 for ; Tue, 20 Sep 2016 16:41:41 +0000 (UTC) Received: from localhost (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8KGfeur017126; Tue, 20 Sep 2016 12:41:41 -0400 Date: Tue, 20 Sep 2016 16:42:00 -0000 From: Jonathan Wakely To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Implement floordiv operator for gdb.Value Message-ID: <20160920164140.GC5736@redhat.com> References: <20160920132633.GA897@redhat.com> <883c76d5-54e9-e8fe-5713-eec2c4010498@redhat.com> <20160920163556.GB5736@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160920163556.GB5736@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.0 (2016-08-17) X-SW-Source: 2016-09/txt/msg00230.txt.bz2 On 20/09/16 17:35 +0100, Jonathan Wakely wrote: >On 20/09/16 16:33 +0100, Pedro Alves wrote: >>>@@ -1142,7 +1160,15 @@ valpy_binop_throw (enum valpy_opcode opcode, PyObject *self, PyObject *other) >>> } >>> >>> if (res_val) >>>- result = value_to_value_object (res_val); >>>+ { >>>+ if (floor_it) >>>+ { >>>+ double d = value_as_double (res_val); >> >>Should be s/double/DOUBLEST, I suppose? > >OK - if I do that then floor(d) will convert it back to double, >unless you #include and using std::floor, so that the overload >for long double is visible (in C++ names like floor are >overloaded so you don't need to use floorf/floor/floorl according to >the type). P.S. In theory it should work with and without the using-declaration, but with GCC that wasn't true until GCC 6.1 (see http://developerblog.redhat.com/2016/02/29/why-cstdlib-is-more-complicated-than-you-might-think/ for the gory details). So to get the right result for older versions of GCC you need .