From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls
Date: Mon, 19 Sep 2016 16:18:00 -0000 [thread overview]
Message-ID: <20160919161824.53B15FFEFB@oc8523832656.ibm.com> (raw)
In-Reply-To: <cf88e482-18d4-8b4a-7c73-ba113600fd57@redhat.com> from "Pedro Alves" at Sep 19, 2016 04:59:15 PM
> On 09/19/2016 04:23 PM, Pedro Alves wrote:
> > On 09/19/2016 03:56 PM, Ulrich Weigand wrote:
> >> Pedro Alves wrote:
> >>
> >>> I tried a --disable-nls with both gcc 5.1 and 4.7 here, and it
> >>> doesn't trigger this. I can't seem to find the libintl.h inclusion
> >>> you're seeing. Sounds like that was changed at some point.
> >>
> >> Yes, it looks like these days the C++ headers include a lot fewer
> >> of the base C headers (fixing namespace pollution, maybe?).
> >
> > Yeah, I assume so.
> >
> >>> Alternatively, simply remove the troublesome *gettext and *textdomain
> >>> macros, leaving only the _ and N_ ones. I can't seem to find any
> >>> directly reference to gettext in the tree. The textdomain calls
> >>> in main.c would need to be wrapped in #ifdef ENABLE_NLS, but
> >>> likes like that is all.
> >>
> >> This would also work, and seems the cleanest solution.
> >
> > OK, I'm testing a patch.
>
> I've pushed this in now.
Thanks, Pedro!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2016-09-19 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 16:52 [PATCH] gdb: Use std::max and std::min throughout Pedro Alves
2016-09-15 17:47 ` Simon Marchi
2016-09-16 19:01 ` Pedro Alves
2016-09-18 23:26 ` [pushed] gdb: Fix std::{min, max}-related build breakage on 32-bit hosts Pedro Alves
2016-09-18 23:37 ` [pushed] gdb/s390: Fix build breakage due to std::min/std::max usage without header Pedro Alves
2016-09-19 11:47 ` [PATCH] gdb: Use std::max and std::min throughout Ulrich Weigand
2016-09-19 13:36 ` Pedro Alves
2016-09-19 13:44 ` Pedro Alves
2016-09-19 14:02 ` Pedro Alves
2016-09-19 14:56 ` Ulrich Weigand
2016-09-19 15:23 ` Pedro Alves
2016-09-19 15:59 ` [pushed] gdb: Fix build breakage with GCC 4.1 and --disable-nls Pedro Alves
2016-09-19 16:18 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919161824.53B15FFEFB@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox