From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104035 invoked by alias); 19 Sep 2016 14:56:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104018 invoked by uid 89); 19 Sep 2016 14:56:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=alternatively X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Sep 2016 14:56:56 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8JEriZW077899 for ; Mon, 19 Sep 2016 10:56:54 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0b-001b2d01.pphosted.com with ESMTP id 25h2140fc0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 19 Sep 2016 10:56:53 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Sep 2016 15:56:52 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Sep 2016 15:56:42 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id A298F17D805D for ; Mon, 19 Sep 2016 15:58:39 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8JEufSt3473888 for ; Mon, 19 Sep 2016 14:56:41 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8JEuf5X018322 for ; Mon, 19 Sep 2016 10:56:41 -0400 Received: from oc8523832656.ibm.com (dyn-9-152-213-149.boeblingen.de.ibm.com [9.152.213.149]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8JEufMS018304; Mon, 19 Sep 2016 10:56:41 -0400 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id AFC84100083; Mon, 19 Sep 2016 16:56:40 +0200 (CEST) Subject: Re: [PATCH] gdb: Use std::max and std::min throughout To: palves@redhat.com (Pedro Alves) Date: Mon, 19 Sep 2016 14:56:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Pedro Alves" at Sep 19, 2016 02:35:52 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091914-0032-0000-0000-00000217DFFD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091914-0033-0000-0000-00001CF47CF8 Message-Id: <20160919145640.AFC84100083@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-19_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609190201 X-SW-Source: 2016-09/txt/msg00209.txt.bz2 Pedro Alves wrote: > I tried a --disable-nls with both gcc 5.1 and 4.7 here, and it > doesn't trigger this. I can't seem to find the libintl.h inclusion > you're seeing. Sounds like that was changed at some point. Yes, it looks like these days the C++ headers include a lot fewer of the base C headers (fixing namespace pollution, maybe?). > How about always including libintl.h, even when ENABLE_NLS: > > #ifdef HAVE_LIBINTL_H > # include > #endif It looks like this would fix the problem for me. > Alternatively, simply remove the troublesome *gettext and *textdomain > macros, leaving only the _ and N_ ones. I can't seem to find any > directly reference to gettext in the tree. The textdomain calls > in main.c would need to be wrapped in #ifdef ENABLE_NLS, but > likes like that is all. This would also work, and seems the cleanest solution. > Seems like gas/asintl.h handles this in yet another way [1]. > That one seems too much of a hack to me, though. Agreed. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com