From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78153 invoked by alias); 13 Sep 2016 15:37:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78129 invoked by uid 89); 13 Sep 2016 15:37:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=love X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Sep 2016 15:37:09 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8DFWm9R060284 for ; Tue, 13 Sep 2016 11:37:08 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 25dxu4sctw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 13 Sep 2016 11:37:08 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Sep 2016 16:37:06 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 Sep 2016 16:37:02 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id BCB3417D805A for ; Tue, 13 Sep 2016 16:38:57 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8DFb2mi27066526 for ; Tue, 13 Sep 2016 15:37:02 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8DFb1LK009551 for ; Tue, 13 Sep 2016 09:37:02 -0600 Received: from oc8523832656.ibm.com (dyn-9-152-213-149.boeblingen.de.ibm.com [9.152.213.149]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8DFb1iE009545; Tue, 13 Sep 2016 09:37:01 -0600 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 960F411C2B7; Tue, 13 Sep 2016 17:37:01 +0200 (CEST) Subject: Re: [PATCH] Fix for gdb.server/non-existing-program.exp test case To: cel@us.ibm.com (Carl E. Love) Date: Tue, 13 Sep 2016 15:37:00 -0000 From: "Ulrich Weigand" Cc: arnez@linux.vnet.ibm.com (Andreas Arnez), gdb-patches@sourceware.org, emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), Ulrich.Weigand@de.ibm.com (Ulrich Weigand) In-Reply-To: <1473780307.4102.115.camel@us.ibm.com> from "Carl E. Love" at Sep 13, 2016 08:25:07 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091315-0040-0000-0000-00000225F951 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091315-0041-0000-0000-000021B63436 Message-Id: <20160913153701.960F411C2B7@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-13_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609130229 X-SW-Source: 2016-09/txt/msg00097.txt.bz2 Carl Love wrote: > I fixed up the comment per your suggestion. Not sure what happened with > the formatting. See if this looks better. > + /* The last_status.kind was set by the call to ptrace(PTRACE_TRACEME, ...). > + The function linux_wait() has also been called. At this point, the > + target process, if it exits, is stopped. Do not call the function > + target_post_create_inferior if the process has already exited, as the > + target implementation of the routine may rely on the process being live. > + */ Formatting looks OK now, except that the trailing */ should not be on a separate line; see other multi-line comments how those should look like. However, the comment still mentions ptrace and linux_wait, which is also only true on Linux targets. I'd just leave that off. Patch is OK with that change. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com