From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59083 invoked by alias); 23 Aug 2016 16:30:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58972 invoked by uid 89); 23 Aug 2016 16:30:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=fp, love X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Aug 2016 16:30:32 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7NGNn2U041229 for ; Tue, 23 Aug 2016 12:30:30 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2502yqvu5m-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Aug 2016 12:30:30 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Aug 2016 17:30:29 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 23 Aug 2016 17:30:25 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id E00A117D8062 for ; Tue, 23 Aug 2016 17:32:10 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7NGUPsx25428462 for ; Tue, 23 Aug 2016 16:30:25 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7NGUOup028044 for ; Tue, 23 Aug 2016 10:30:24 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-149.boeblingen.de.ibm.com [9.152.213.149]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u7NGUNhn028041; Tue, 23 Aug 2016 10:30:23 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id AAA2B5BCB; Tue, 23 Aug 2016 18:30:23 +0200 (CEST) Subject: Re: [PATCH] Fix for gdb.base/pc-fp.exp. To: cel@us.ibm.com (Carl E. Love) Date: Tue, 23 Aug 2016 16:30:00 -0000 From: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), Ulrich.Weigand@de.ibm.com (Ulrich Weigand), emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org In-Reply-To: <1471969030.4102.52.camel@us.ibm.com> from "Carl E. Love" at Aug 23, 2016 09:17:10 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082316-0028-0000-0000-00000205F16C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082316-0029-0000-0000-000020082E32 Message-Id: <20160823163023.AAA2B5BCB@oc7340732750.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-23_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608230163 X-SW-Source: 2016-08/txt/msg00234.txt.bz2 Carl Love wrote: > That said, the code "set_gdbarch_deprecated_fp_regnum > (gdbarch, PPC_R0_REGNUM + 1);" sets up register r1 as the frame pointer. > Register r1 is no longer used to hold the frame pointer on Power. By > removing the fp definition for Power in GDB, it causes GDB to fall back > to the call get_frame_base_address (frame) which returns the correct value > depending on the specific senario but most of the time is the DWARF > canonical frame address. That's true. In fact, the one place that really cares about the value returned via $fp is varobj.c:find_frame_addr_in_frame_chain, since you're supposed to use the value of $fp to identify a frame for MI routines. And there we explicitly assume that this value matches the value returned by get_frame_base_address. > 2016-08-22 Carl Love > > * rs6000-tdep.c (rs6000_gdbarch_init): Remove deprecated call set_gdbarch_deprecated_fp_regnum() > from Power architecture initialization function. Please watch the 80-char line length limit, which holds for the ChangeLog as well. In fact, the text can be shortened anyway: "deprecated" is redundant (included in the function name), and likewise is "from Power architecture initialization function" (you already specified which function --rs6000_gdbarch_init-- you're modifying). I'd suggest: * rs6000-tdep.c (rs6000_gdbarch_init): Remove call to set_gdbarch_deprecated_fp_regnum. Patch is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com