From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Weinmann, Christoph T" <christoph.t.weinmann@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Heckel, Bernhard" <bernhard.heckel@intel.com>
Subject: Re: [ping] [PATCH v2 0/6] fortran: multi-dimensional subarrays with strides
Date: Sun, 07 Aug 2016 20:12:00 -0000 [thread overview]
Message-ID: <20160807201224.GA10481@host1.jankratochvil.net> (raw)
In-Reply-To: <1E04C56C2A492B449743D653DD4A15BC3BC4C94C@IRSMSX102.ger.corp.intel.com>
Hello Christoph,
0001-fortran-allow-multi-dimensional-subarrays.patch
contains:
+ elt_size = TYPE_LENGTH (elt_type);
+ elt_offs = longest_to_int (lowbound - ary_low_bound);
+ elt_stride = TYPE_LENGTH (TYPE_INDEX_TYPE (array_type));
+
+ elt_offs *= elt_size;
which now causes:
valops.c:3803:11: error: variable ‘elt_stride’ set but not used [-Werror=unused-but-set-variable]
LONGEST elt_stride, ary_high_bound, ary_low_bound;
^~~~~~~~~~
but other patches contained:
+ if (elt_stride > 0)
+ elt_offs *= elt_stride;
[...]
+ else
+ elt_offs *= elt_size;
This may explain some Fortran testcase stride failure I was seeing and
bugreporting to you off-list.
Jan
prev parent reply other threads:[~2016-08-07 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 7:58 Weinmann, Christoph T
2016-04-08 8:05 ` Jan Kratochvil
2016-06-30 21:47 ` Jan Kratochvil
2016-07-01 13:08 ` Weinmann, Christoph T
2016-07-03 20:51 ` Jan Kratochvil
2016-08-07 20:12 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807201224.GA10481@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=bernhard.heckel@intel.com \
--cc=christoph.t.weinmann@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox