From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29031 invoked by alias); 18 Jul 2016 11:40:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29013 invoked by uid 89); 18 Jul 2016 11:40:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 Jul 2016 11:40:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C56D07D0DB; Mon, 18 Jul 2016 11:40:05 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6IBe27R028931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 Jul 2016 07:40:05 -0400 Date: Mon, 18 Jul 2016 11:40:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: "gdb-patches@sourceware.org" Subject: Re: [testsuite patch] Fix gdb.gdb/selftest.exp for C++-O2-g-built GDB Message-ID: <20160718114002.GA26094@host1.jankratochvil.net> References: <20160716131402.GA2961@host1.jankratochvil.net> <20160718081834.GA26110@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00187.txt.bz2 On Mon, 18 Jul 2016 11:45:36 +0200, Yao Qi wrote: > OK, I think we still need to convert gdb.gdb/selftest.exp using proc > do_self_tests to simplify the code, and then, improve procs in > lib/selftest-support.exp to handle the fails when GDB is compiled with > optimization. What do you think? If you agree on this, I can commit > my patch above, and tweak lib/selftest-support.exp to fix your fails. I have no opinion on it. I have no idea what's the purpose of gdb.gdb/selftest.exp . I see during the past 10 years I saw an upstream catch of one regression(s) by but it was more an accident and it could happen with some other regular testsuite-built inferior if it was testing the same feature. I just want to keep it regression-free so do whatever you find fine, I can rebase my patch on top of it, but I would like no regression for -O2 -g GDB and I would like not to carry this patch off-trunk forever. Jan