From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17916 invoked by alias); 18 Jul 2016 11:34:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17902 invoked by uid 89); 18 Jul 2016 11:34:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=metzger X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 Jul 2016 11:33:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA8847D0CA; Mon, 18 Jul 2016 11:33:51 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6IBXmEQ032678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 Jul 2016 07:33:50 -0400 Date: Mon, 18 Jul 2016 11:34:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: "gdb-patches@sourceware.org" , Sergio Durigan Junior Subject: Re: [testsuite patch] Skip py-unwind.exp on x86_64 -m32 Message-ID: <20160718113348.GA25789@host1.jankratochvil.net> References: <20160717143003.GA12147@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00186.txt.bz2 On Mon, 18 Jul 2016 12:04:27 +0200, Yao Qi wrote: > This problem is slightly different from "how to run testsuite in cross-arch > mode", IMO. > py-unwind.py defines a unwinder, in an arch-specific way. It has nothing > wrong. > However, py-unwind.py should be more portable, which means, it should > define unwdiner for each arch it supports, and py-unwind.exp or py-unwind.py > chooses the right python unwinder according to the arch. IOW, we need to > define a python unwinder for i386, and use it when arch is i386. There will always exist at least one unsupported arch for an arch-specific testcase. I do not think it makes sense to say that very every testcase in the testsuite must support very every arch supported by GDB. So we can say that py-unwind.exp just does not support arch i386. I do not find that wrong. Wrong is that it should not FAIL on unsupported arch, it should skip the testcase on unsupported arch. The problem here is that py-unwind.exp thinks that it runs on arch x86_64 but it runs on arch i386. Even if py-unwind.exp did support i386 it would still FAIL because it would run the testcase for %rbp/%rsp/%rip. That is I do not agree with your mail. In fact I think the cross-arch running of the GDB testsuite should be described at https://sourceware.org/gdb/wiki/TestingGDB but currently it is not. Currently there is only https://sourceware.org/gdb/wiki/TestingGDB#Changing_the_compiler_used_to_build_the_testcases which uses the simple way I currently use and which breaks the testsuite needing the ![is_lp64_target] additional test. Maybe GDB maintainers could say that the only valid way to run the testsuite cross-arch is properly setting arget_triplet as Markus Metzger suggests. (But then I would need to fix many scripts of mine; also not sure if Sergio's Buildbot runs it that way.) Jan