From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34764 invoked by alias); 13 Jul 2016 11:52:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34751 invoked by uid 89); 13 Jul 2016 11:52:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Kevin X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 13 Jul 2016 11:52:23 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6DBn4j4035149 for ; Wed, 13 Jul 2016 07:52:21 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2455jt3tkw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 13 Jul 2016 07:52:21 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Jul 2016 12:52:16 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 13 Jul 2016 12:51:51 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4834D17D8056 for ; Wed, 13 Jul 2016 12:53:17 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6DBpojP62455932 for ; Wed, 13 Jul 2016 11:51:50 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6DBpoNi003380 for ; Wed, 13 Jul 2016 05:51:50 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-42.boeblingen.de.ibm.com [9.152.213.42]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u6DBpoBu003366; Wed, 13 Jul 2016 05:51:50 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id D85A52397; Wed, 13 Jul 2016 13:51:49 +0200 (CEST) Subject: Re: [testsuite patchv3] [ppc64] gdb_target_symbol fix for function descriptors [Re: [testsuite patch] [ppc64] +kfail: gdb_target To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Wed, 13 Jul 2016 11:52:00 -0000 From: "Ulrich Weigand" Cc: qiyaoltc@gmail.com (Yao Qi), gdb-patches@sourceware.org (gdb-patches@sourceware.org), kevinb@redhat.com (Kevin Buettner) In-Reply-To: <20160713085400.GA1159@host1.jankratochvil.net> from "Jan Kratochvil" at Jul 13, 2016 10:54:00 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071311-0040-0000-0000-000002A9BAAC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071311-0041-0000-0000-00001C3366FB Message-Id: <20160713115149.D85A52397@oc7340732750.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-13_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607130132 X-SW-Source: 2016-07/txt/msg00143.txt.bz2 Jan Kratochvil wrote: > On Tue, 12 Jul 2016 15:22:49 +0200, Ulrich Weigand wrote: > > See e.g. dw2-unresolved-main.c: > > > > asm (".globl cu_text_start"); > > asm ("cu_text_start:"); > > I wrote those lines... > > I just did not want to patch multiple (3) testcases one after another just > because one platform (ppc64). Ah, I see :-) > So I am providing this patch. On Fedora 24 x86_64 and RHEL-7.2 ppc64 it has > no regressions for gdb.dwarf2/*.exp. Right, this is even better. I hadn't even noticed this new library routine. > OK for check-in? > > Kevin, I hope gdb_target_symbol is not needed in this case but I am not sure. >From what I can see, it should indeed not be needed: the _label symbols are defined by assembler code directly, and therefore gdb_target_symbol does not apply, while the compiler-defined symbols like are only accessed via GDB commands in function_range (and GDB should already do the right thing w.r.t. symbol prefixes). The patch is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com