On Tue, 12 Jul 2016 15:22:49 +0200, Ulrich Weigand wrote:
> See e.g. dw2-unresolved-main.c:
> 
> asm (".globl cu_text_start");
> asm ("cu_text_start:");

I wrote those lines...

I just did not want to patch multiple (3) testcases one after another just
because one platform (ppc64).

Now I see I should not do that because:

lib/dwarf.exp:
# asm ("func_start: .globl func_start");
# static void func (void) {}
# asm ("func_end: .globl func_end");
#
# however, this isn't portable, because other compilers, such as clang,
# may not guarantee the order of global asms and function.  The code
# becomes:
#
# asm ("func_start: .globl func_start");
# asm ("func_end: .globl func_end");
# static void func (void) {}
#
proc function_range { func src } {

commit 876c4df94765ce9409e867ff035ab2203c9f4a3b
Author: Yao Qi <yao@codesourcery.com>
Date:   Fri Nov 14 08:53:08 2014 +0800
    DW attribute macro MACRO_AT_func and MACRO_AT_range


So I am providing this patch.  On Fedora 24 x86_64 and RHEL-7.2 ppc64 it has
no regressions for gdb.dwarf2/*.exp.

OK for check-in?

Kevin, I hope gdb_target_symbol is not needed in this case but I am not sure.


Thanks,
Jan