From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34814 invoked by alias); 5 Jul 2016 17:39:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34803 invoked by uid 89); 5 Jul 2016 17:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=outbound, Hx-languages-length:1309, misconfigured X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jul 2016 17:39:51 +0000 Received: from ball (unknown [IPv6:2607:f0c8:8000:80e0:56ee:75ff:fe52:afb9]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 043B4C094; Tue, 5 Jul 2016 17:39:50 +0000 (UTC) Date: Tue, 05 Jul 2016 17:39:00 -0000 From: Trevor Saunders To: Manish Goregaokar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Allow subscripting raw pointers Message-ID: <20160705174710.GA20061@ball> References: <87r3b8gfyd.fsf@tromey.com> <1467739954112.ab2ed64e1ba@mozgaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467739954112.ab2ed64e1ba@mozgaia> User-Agent: Mutt/1.6.0 (2016-04-01) X-SW-Source: 2016-07/txt/msg00080.txt.bz2 On Tue, Jul 05, 2016 at 10:32:38AM -0700, Manish Goregaokar wrote: > I am using git format-patch and pasting it into GMail text mode. Probably should set up mutt; haven't yet because I was behind a port-blocked university connection for years :) fwiw while people usually block 25 I don't think I've ever seen someone block 587. > I'll see what I can do. you might want to try git send-email if your going to make gmail handle outbound smtp for you already. Trev > > Tom Tromey wrote: > > Manish> 2016-07-04 Manish Goregaokar > > Manish> gdb/ChangeLog: > > Manish> * rust-lang.c (rust_subscript): Allow subscripting pointers > > Manish> gdb/testsuite/ChangeLog: > > Manish> * simple.rs: Add test for raw pointer subscripting > > Manish> * simple.exp: Add test expectations > > > > This is ok. Thanks. > > > > Manish> + else if (TYPE_CODE (type) == TYPE_CODE_PTR) > > Manish> + { > > Manish> + base = lhs; > > Manish> + low_bound = 0; > > Manish> + high_bound = LONGEST_MAX; > > Manish> + } > > Manish> else > > > > I suspect maybe your MUA is misconfigured somehow? Your patches often > > come out looking like the indentation is messed up; but in this case the > > context makes it clear that the indentation is probably ok. > > > > Tom