From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75931 invoked by alias); 5 Jul 2016 16:36:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75919 invoked by uid 89); 5 Jul 2016 16:36:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=avenue, Hx-languages-length:1129, deciding, sk:gdb_rem X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 05 Jul 2016 16:36:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B4F861169FA; Tue, 5 Jul 2016 12:36:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RrF2ZLrLC20A; Tue, 5 Jul 2016 12:36:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6BA0F1169F4; Tue, 5 Jul 2016 12:36:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E0412428F4; Tue, 5 Jul 2016 09:36:11 -0700 (PDT) Date: Tue, 05 Jul 2016 16:36:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: gdbserver/ada testing broken (was: Re: [pushed] Fix gdbserver/MI testing regression) Message-ID: <20160705163611.GJ3295@adacore.com> References: <1462538104-19109-1-git-send-email-palves@redhat.com> <1462538104-19109-32-git-send-email-palves@redhat.com> <5772DBCA.4090802@ericsson.com> <813555f3-c917-cd95-6d41-3ec64cad2cf6@redhat.com> <14e113dd-0488-79d0-6cde-82cdb1562793@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-07/txt/msg00075.txt.bz2 > This is probably because gdb_remote_download only minds "tail" when > deciding the destination filename: > > proc gdb_remote_download {dest fromfile {tofile {}}} { > # If TOFILE is not given, default to the same filename as FROMFILE. > if {[string length $tofile] == 0} { > set tofile [file tail $fromfile] > } Looks like this code is indirectly assuming that the code is in the same directory as the .exp. That's why it can extract the target directory via a simple "tail". I tried looking at whether we could make sure "tofile" was explicitly passed at least for Ada, but it doesn't look really like an option, as I think this comes from gdb_file_cmd where, logically, all we care about is which executable to load into GDB. I am running out of time to investigate this for now, but to me, thinking this further, I think the most promising avenue is probably to look at eliminating the subdirectory, since our testing procedure now creates one per test already. But I'm not sure how this is going to affect in-tree testing. -- Joel