From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45916 invoked by alias); 9 Jun 2016 18:09:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45846 invoked by uid 89); 9 Jun 2016 18:09:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 09 Jun 2016 18:09:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C158D116E7A; Thu, 9 Jun 2016 14:09:08 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VZoDurZdIV6K; Thu, 9 Jun 2016 14:09:08 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 91941116E36; Thu, 9 Jun 2016 14:09:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 137A2428DD; Thu, 9 Jun 2016 11:09:07 -0700 (PDT) Date: Thu, 09 Jun 2016 18:09:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] PR python/19819 - remove unused globals from py-xmethods.c Message-ID: <20160609180907.GA3910@adacore.com> References: <1465490788-8356-1-git-send-email-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465490788-8356-1-git-send-email-tom@tromey.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-06/txt/msg00186.txt.bz2 > PR python/19819 concerns some unused global variables in > py-xmethods.c. This patch deletes the unused globals. > > Tested by rebuilding. > > 2016-06-09 Tom Tromey > > PR python/19819: > * python/py-xmethods.c (invoke_method_name) > (py_get_result_type_method_name, py_invoke_method_name): Remove. > (gdbpy_initialize_xmethods): Don't initialize > py_invoke_method_name, py_get_result_type_method_name. Looks OK to me. Can we consider this one obvious too? I think so! Thanks, Tom! -- Joel