From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-132003-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9378 invoked by alias); 8 Jun 2016 02:30:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9368 invoked by uid 89); 8 Jun 2016 02:30:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:661, pushing, UD:warning.m4, build_warnings
X-HELO: paperclip.tbsaunde.org
Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jun 2016 02:30:40 +0000
Received: from ball (CPE00fc8d3ff2d3-CM00fc8d3ff2d0.cpe.net.cable.rogers.com [99.242.1.93])	by paperclip.tbsaunde.org (Postfix) with ESMTPSA id E89FBC0B9;	Wed,  8 Jun 2016 02:30:38 +0000 (UTC)
Date: Wed, 08 Jun 2016 02:30:00 -0000
From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 6/6] Add -Wunused-but-set-* to build
Message-ID: <20160608023751.GC30231@ball>
References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-7-git-send-email-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1465248812-23902-7-git-send-email-tom@tromey.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SW-Source: 2016-06/txt/msg00147.txt.bz2

On Mon, Jun 06, 2016 at 03:33:32PM -0600, Tom Tromey wrote:
> This adds -Wunused-but-set-variable and -Wunused-but-set-parameter to
> configure.

 great, I started on that a little while ago but didn't get to pushing
 these bits upstream.

> +++ b/gdb/warning.m4
> @@ -39,7 +39,7 @@ fi
>  build_warnings="-Wall -Wpointer-arith \
>  -Wno-unused -Wunused-value -Wunused-function \
>  -Wno-switch -Wno-char-subscripts \
> --Wempty-body"
> +-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable"

isn't everything in -Wunused enabled now? can we just delete -Wno-unused
and use -Wall to get us -Wunused?

Trev